Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix register command. #264

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

SkidGod4444
Copy link

@SkidGod4444 SkidGod4444 commented Oct 8, 2024

Date: 08-10-2024

Developer Name: Saidev Dhal


Description

Fixed the npm run register command. So that it will not cause any error next time.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

image

Test Coverage

Screenshot 1

image

Additional Notes

This issue as existing before i just wanted to fix it so updated the package command.

@vinit717
Copy link
Member

vinit717 commented Oct 9, 2024

Can you add an issue ticket for this
describing the error

@SkidGod4444
Copy link
Author

Can you add an issue ticket for this describing the error

Done, sir added the issue ticket.

@vinit717 vinit717 linked an issue Oct 9, 2024 that may be closed by this pull request
10 tasks
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to know, how it was working before

@joyguptaa
Copy link
Contributor

joyguptaa commented Oct 11, 2024

I want to know, how it was working before

Hello @iamitprakash I am also not sure about how it was working before. We faced this issue while trying to set up the Discord-slash-command on Saidev's system.
Also when I was doing my setup in February for the discord-slash command, I, too, faced this issue. And to this day, it doesn't work on my system.

Screenshot 2024-10-11 at 11 17 28 PM

@SkidGod4444
Copy link
Author

SkidGod4444 commented Oct 16, 2024

I want to know how it was working before

Earlier versions of Node.js were more forgiving with module resolution, allowing ts-node-esm to work. With Node.js v20, stricter rules were introduced, causing issues like ERR_UNKNOWN_FILE_EXTENSION. These new rules require better handling of ESM-specific features, which is why ts-node-esm is failing now while ts-node (which uses CommonJS) continues to work fine.

Hence, systems having Node.js v20 or earlier are facing this issue, and others are not.

Reference: GitHub issue.

@SkidGod4444 SkidGod4444 changed the title fix register command & update jest version fix register command. Oct 16, 2024
@iamitprakash
Copy link
Member

I want to know, how it was working before

Earlier versions of Node.js were more forgiving with module resolution, allowing ts-node-esm to work. With Node.js v20, stricter rules were introduced, causing issues like ERR_UNKNOWN_FILE_EXTENSION. These new rules require better handling of ESM-specific features, which is why ts-node-esm might fail now while ts-node (which uses CommonJS) continues to work fine.

Hence systems having Node.js v20 or earlier are facing this issue and others are not.

Reference: GitHub issue.

Hello @SkidGod4444 I will not go with your might word, need crystal clear answers

@SkidGod4444
Copy link
Author

SkidGod4444 commented Oct 18, 2024

I want to know, how it was working before

Earlier versions of Node.js were more forgiving with module resolution, allowing ts-node-esm to work. With Node.js v20, stricter rules were introduced, causing issues like ERR_UNKNOWN_FILE_EXTENSION. These new rules require better handling of ESM-specific features, which is why ts-node-esm might fail now while ts-node (which uses CommonJS) continues to work fine.
Hence systems having Node.js v20 or earlier are facing this issue and others are not.
Reference: GitHub issue.

Hello @SkidGod4444 I will not go with your might word, need crystal clear answers

Sorry for that MIGHT word but that is the appropriate reason for this issue. I also updated the comment now:

#264 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix register command & update jest version
7 participants