Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat landing page #13

Merged
merged 9 commits into from
Dec 5, 2024
Merged

Feat landing page #13

merged 9 commits into from
Dec 5, 2024

Conversation

MehulKChaudhari
Copy link
Member

@MehulKChaudhari MehulKChaudhari commented Nov 24, 2024

Date: 27 Mar 2024

Developer Name: @MehulKChaudhari


Description

Added the landing page with the following components and features:

  1. Hero section with RDS branding and welcome message
  2. "What are Feature Flags?" section explaining the core concept
  3. "Why Use Feature Flags?" section highlighting key benefits

Key files added:

  • src/pages/Landing.tsx
  • src/components/landing/ScrollIndicator.tsx
  • src/constants/landing.ts
  • And tests of above page and component.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • Yes

Screenshots

Screen.Recording.2024-11-24.at.9.08.18.PM.mov

Test Coverage

Test Results image

lakshayman
lakshayman previously approved these changes Nov 25, 2024
tests/pages/Landing.test.tsx Show resolved Hide resolved
src/components/landing/ScrollIndicator.tsx Show resolved Hide resolved
src/pages/Landing.tsx Outdated Show resolved Hide resolved
src/pages/Landing.tsx Show resolved Hide resolved
Base automatically changed from setup/routing to develop December 5, 2024 18:31
@lakshayman lakshayman dismissed stale reviews from Achintya-Chatterjee and themself December 5, 2024 18:31

The base branch was changed.

@tejaskh3 tejaskh3 merged commit ad7d989 into develop Dec 5, 2024
1 check failed
@tejaskh3 tejaskh3 deleted the feat/landing-page branch December 5, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants