Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type error in AuthScreen.tsx #465

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: type error in AuthScreen.tsx #465

wants to merge 1 commit into from
+50 −29

Conversation

surajmaity1
Copy link

@surajmaity1 surajmaity1 commented Oct 9, 2024 •
edited
Loading

Date: 09-10-2024

Developer Name: Suraj Maity

Issue Ticket Number

Description

  • Variables' data type explicitly defined.
  • Unnecessary comments removed.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
Camera.QR.Verif.mp4

Test Coverage

Screenshot 1

Additional Notes

@surajmaity1
Copy link
Author

@ashifkhn please review and approve this PR.

vinit717
vinit717 reviewed Oct 10, 2024
View reviewed changes
src/context/type.ts Outdated Show resolved Hide resolved
@surajmaity1 surajmaity1 force-pushed the refact/auth-screen branch 3 times, most recently from a7fd2ed to 381b488 Compare October 16, 2024 03:57
shreya-mishra
shreya-mishra previously approved these changes Oct 18, 2024
View reviewed changes
@vinit717
Copy link
Member

Can you add the screenshot

@surajmaity1
Copy link
Author

Can you add the screenshot

Screenshots added.

Ayushsanjdev
Ayushsanjdev suggested changes Oct 19, 2024
View reviewed changes
src/react-native-walkthrough-tooltip.d.ts Show resolved Hide resolved
src/screens/AuthScreen/AuthScreen.tsx Show resolved Hide resolved
src/screens/AuthScreen/AuthScreen.tsx Outdated Show resolved Hide resolved
@satyam73 satyam73 marked this pull request as draft October 19, 2024 14:53
@satyam73 satyam73 marked this pull request as ready for review October 19, 2024 14:53
vinit717
vinit717 requested changes Oct 20, 2024
View reviewed changes
src/react-native-walkthrough-tooltip.d.ts Show resolved Hide resolved
src/screens/AuthScreen/AuthScreen.tsx Outdated Show resolved Hide resolved
src/screens/AuthScreen/AuthScreen.tsx Show resolved Hide resolved
iamitprakash
iamitprakash requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need to store token and why we need social media i'ds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ayushsanjdev Ayushsanjdev Ayushsanjdev approved these changes

@iamitprakash iamitprakash iamitprakash requested changes

@shreya-mishra shreya-mishra Awaiting requested review from shreya-mishra

@vinit717 vinit717 Awaiting requested review from vinit717

Requested changes must be addressed to merge this pull request.

Assignees

@surajmaity1 surajmaity1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix type errors in AuthScreen.tsx
6 participants
@surajmaity1 @vinit717 @iamitprakash @shreya-mishra @Ayushsanjdev @ashifkhn