change permitted routes to non auth routes

Real-Dev-Squad · Jul 26, 2024 · 53173b7 · 53173b7
1 parent fd78cc2
commit 53173b7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/skill-tree/src/main/java/com/RDS/skilltree/config/SecurityConfig.java b/skill-tree/src/main/java/com/RDS/skilltree/config/SecurityConfig.java
@@ -27,7 +27,7 @@ public class SecurityConfig {
     private final AuthEntryPoint authEntryPoint;
     private final CustomAccessDeniedHandler accessDeniedHandler;
 
-    public static final List<String> PERMITTED_PATHS = List.of("/v1/health", "/v1/auth");
+    public static final List<String> NON_AUTH_ROUTES = List.of("/v1/health", "/v1/auth");
 
     public SecurityConfig(
             AuthEntryPoint authEntryPoint, CustomAccessDeniedHandler accessDeniedHandler) {
@@ -44,7 +44,7 @@ public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
                                 httpSecurityCorsConfigurer.configurationSource(corsConfigurationSource()))
                 .authorizeHttpRequests(
                         auth -> {
-                            PERMITTED_PATHS.forEach(path -> auth.requestMatchers(path + "/**").permitAll());
+                            NON_AUTH_ROUTES.forEach(path -> auth.requestMatchers(path + "/**").permitAll());
                             auth.requestMatchers(HttpMethod.GET, "/v1/**")
                                     .hasAnyAuthority(UserRoleEnum.getAllRoles()) // give read-only access to all
                                     .requestMatchers("/v1/**")

diff --git a/skill-tree/src/main/java/com/RDS/skilltree/utils/JWTAuthenticationFilter.java b/skill-tree/src/main/java/com/RDS/skilltree/utils/JWTAuthenticationFilter.java
@@ -52,7 +52,7 @@ public void doFilterInternal(
     @Override
     protected boolean shouldNotFilter(HttpServletRequest request) throws ServletException {
         String path = request.getRequestURI();
-        return SecurityConfig.PERMITTED_PATHS.stream().anyMatch(path::startsWith);
+        return SecurityConfig.NON_AUTH_ROUTES.stream().anyMatch(path::startsWith);
     }
 
     public String getJWTFromRequest(HttpServletRequest request) {