-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config/env vars #68
Merged
Merged
Config/env vars #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Achintya-Chatterjee
previously approved these changes
Mar 15, 2024
process-env.d.ts
Outdated
@@ -6,5 +6,6 @@ declare namespace NodeJS { | |||
NEXT_PUBLIC_WELCOME_SITE: string; | |||
NEXT_PUBLIC_WWW_SITE: string; | |||
NEXT_PUBLIC_MY_SITE: string; | |||
NEXT_PUBLIC_APP_ENV: "development" | "production" | "test" | "development"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no staging here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added thanks for pointing out!
Achintya-Chatterjee
approved these changes
Mar 18, 2024
iamitprakash
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
14-03-2024
Developer Name: Satyam Bajpai
Issue Ticket Number
Description
Warning : This PR should be merged when
NEXT_PUBLIC_APP_ENV
is set in environment variables where our staging and production are deployed.Production
NEXT_PUBLIC_APP_ENV -
production
Staging
NEXT_PUBLIC_APP_ENV -
staging
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes