Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

block domain tiny.realdevsquad.com while creating tiny url #138

Merged
merged 6 commits into from
Dec 18, 2024

Conversation

fakhruddinkw
Copy link
Contributor

@fakhruddinkw fakhruddinkw commented Dec 2, 2024

Issue Ticket Number

This PR takes care of #131

Description

Changes in this PR will not let a user create a tiny url of the active tiny url

Breaking Changes

  • Yes
  • No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.

Development Tested?

  • Yes
  • No

Confirm whether the changes have been tested locally during development.

Tested in Staging?

  • Yes
  • No

Indicate whether the changes have been tested in the staging environment for dev to main.

Database Changes

  • Yes
  • No

Indicate whether the changes include modifications to the database.

Screenshots

block-domains-task.mp4

Additional Notes

Include any additional notes, considerations, or explanations that might be helpful for reviewers.

@vinit717
Copy link
Member

vinit717 commented Dec 4, 2024

Can you pass me the design doc so I can get the what approach you are following

@iamitprakash
Copy link
Member

iamitprakash commented Dec 4, 2024 via email

@fakhruddinkw
Copy link
Contributor Author

please remove logic from controller *

On Wed, Dec 4, 2024 at 4:44 PM Vinit khandal @.
> wrote: Can you pass me the design doc so I can get the what approach you are following — Reply to this email directly, view it on GitHub <#138 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIKA665CVCMQB5NNDXJ3NFL2D3P2JAVCNFSM6AAAAABS36NSFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJXGAYTQMRQHA . You are receiving this because your review was requested.Message ID: @.*>

On it!

@fakhruddinkw
Copy link
Contributor Author

Can you pass me the design doc so I can get the what approach you are following

As I believed this was a straight solution, I didn't make any design doc. However I did go through the doc which sebin (last assignee) made.

controllers/url.go Outdated Show resolved Hide resolved
@fakhruddinkw fakhruddinkw requested a review from yesyash December 17, 2024 18:48
controllers/url.go Outdated Show resolved Hide resolved
@fakhruddinkw fakhruddinkw requested a review from yesyash December 18, 2024 09:35
Copy link
Member

@vinit717 vinit717 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintain the follow up for enhancement

@fakhruddinkw
Copy link
Contributor Author

Maintain the follow up for enhancement

picking it up right after this! thank you

@yesyash yesyash merged commit 322af53 into develop Dec 18, 2024
1 check passed
@yesyash yesyash deleted the enhancement/block-domains branch December 18, 2024 18:04
@fakhruddinkw fakhruddinkw self-assigned this Dec 18, 2024
@fakhruddinkw fakhruddinkw mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants