-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
block domain tiny.realdevsquad.com while creating tiny url #138
Conversation
Can you pass me the design doc so I can get the what approach you are following |
*please remove logic from controller *
…On Wed, Dec 4, 2024 at 4:44 PM Vinit khandal ***@***.***> wrote:
Can you pass me the design doc so I can get the what approach you are
following
—
Reply to this email directly, view it on GitHub
<#138 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIKA665CVCMQB5NNDXJ3NFL2D3P2JAVCNFSM6AAAAABS36NSFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJXGAYTQMRQHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
On it! |
As I believed this was a straight solution, I didn't make any design doc. However I did go through the doc which sebin (last assignee) made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maintain the follow up for enhancement
picking it up right after this! thank you |
Issue Ticket Number
This PR takes care of #131
Description
Changes in this PR will not let a user create a tiny url of the active tiny url
Breaking Changes
If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.
Development Tested?
Confirm whether the changes have been tested locally during development.
Tested in Staging?
Indicate whether the changes have been tested in the staging environment for dev to main.
Database Changes
Indicate whether the changes include modifications to the database.
Screenshots
block-domains-task.mp4
Additional Notes
Include any additional notes, considerations, or explanations that might be helpful for reviewers.