Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: block tiny url domain while creating tiny url #140

Closed
wants to merge 7 commits into from

Conversation

fakhruddinkw
Copy link
Contributor

Issue Ticket Number

#131

Description

As the config variable on our machine also has http scheme, the string.Contains fails. Now parsing the config.Domain should fix this.

Breaking Changes

  • Yes
  • No

If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.

Development Tested?

  • Yes
  • No

Confirm whether the changes have been tested locally during development.

Tested in Staging?

  • Yes
  • No

Indicate whether the changes have been tested in the staging environment for dev to main.

Database Changes

  • Yes
  • No

Indicate whether the changes include modifications to the database.

Screenshots

Attach any relevant screenshots, such as test coverage reports, before and after images, or other visual aids.

Additional Notes

Include any additional notes, considerations, or explanations that might be helpful for reviewers.

@fakhruddinkw fakhruddinkw deleted the enhancement/block-domains branch December 21, 2024 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant