Add WEB_APP_BASE_URL #143
Merged
Add WEB_APP_BASE_URL #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
prakashchoudhary07
added a commit
that referenced
this pull request
Jan 13, 2025
* block domain tiny.realdevsquad.com while creating a tiny url (#138) * added code to block the creation of tiny url of the tiny url * removing sql query for checking existing tiny url * adding tests * forgot to add auth in test * fixed error message * removed hardcoding from error message * chore: add new env in deploy ci (#143) * Fix: block tiny url domain while creating tiny url (#141) * fix/block-domain * Added new config variable and made changes according to it * adding new config to test.env * fixing tests * fixed name of the config var * resolving merge conflicts * Revert "resolving merge conflicts" This reverts commit bf01b08. * Merge pull request #146 from Real-Dev-Squad/fix/restore-docker-file-to-previous-version Revert docker changes --------- Co-authored-by: Prakash Choudhary <[email protected]> Co-authored-by: Prakash <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Ticket Number
Description
Add a new env variable
WEB_APP_BASE_URLwith valuehttps://staging-tiny.realdevsquad.com/Breaking Changes
If your feature introduces breaking changes or if something is missing, please mention the related issue tickets.
Development Tested?
Confirm whether the changes have been tested locally during development.
Tested in Staging?
Indicate whether the changes have been tested in the staging environment for dev to main.
Database Changes
Indicate whether the changes include modifications to the database.
Screenshots
Attach any relevant screenshots, such as test coverage reports, before and after images, or other visual aids.
Additional Notes
Include any additional notes, considerations, or explanations that might be helpful for reviewers.