Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: inDiscord #1060

Merged
merged 11 commits into from
May 19, 2023
Merged

Feature: inDiscord #1060

merged 11 commits into from
May 19, 2023

Conversation

bhtibrewal
Copy link
Contributor

@bhtibrewal bhtibrewal commented Apr 28, 2023 •
edited
Loading

Requirement

Made API for getting in_discord and verified users
add search queries role & verified to/search

@bhtibrewal bhtibrewal marked this pull request as draft April 28, 2023 16:47
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 28, 2023
View reviewed changes
routes/users.js Fixed Show fixed Hide fixed
routes/users.js Fixed Show fixed Hide fixed
@bhtibrewal bhtibrewal mentioned this pull request Apr 30, 2023
Closed
@bhtibrewal bhtibrewal self-assigned this Apr 30, 2023
@bhtibrewal bhtibrewal added the feature task Feature that has to be built label Apr 30, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems May 2, 2023
View reviewed changes
routes/users.js Fixed Show fixed Hide fixed
routes/users.js Fixed Show fixed Hide fixed
routes/users.js Fixed Show fixed Hide fixed
@bhtibrewal bhtibrewal marked this pull request as ready for review May 15, 2023 06:15
@bhtibrewal bhtibrewal changed the title Feature: inDiscord Feature: inDiscord May 17, 2023
bhtibrewal
bhtibrewal commented May 18, 2023
View reviewed changes
controllers/users.js Show resolved Hide resolved
models/users.js Show resolved Hide resolved
DashDeipayan
DashDeipayan suggested changes May 18, 2023
View reviewed changes
constants/roles.js Show resolved Hide resolved
controllers/users.js Show resolved Hide resolved
models/users.js Outdated Show resolved Hide resolved
models/users.js Outdated Show resolved Hide resolved
models/users.js Outdated Show resolved Hide resolved
test/fixtures/user/user.js Show resolved Hide resolved
test/fixtures/user/user.js Show resolved Hide resolved
heyrandhir
heyrandhir suggested changes May 18, 2023
View reviewed changes
controllers/users.js Show resolved Hide resolved
middlewares/validators/user.js Outdated Show resolved Hide resolved
middlewares/validators/user.js Show resolved Hide resolved
models/users.js Show resolved Hide resolved
DashDeipayan
DashDeipayan approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@DashDeipayan DashDeipayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhtibrewal bhtibrewal merged commit a4952ed into develop May 19, 2023
@bhtibrewal bhtibrewal deleted the feature/inDiscord branch May 19, 2023 16:30
@bhtibrewal bhtibrewal mentioned this pull request May 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DashDeipayan DashDeipayan DashDeipayan approved these changes

@heyrandhir heyrandhir heyrandhir approved these changes

Assignees

@bhtibrewal bhtibrewal

Labels
feature task Feature that has to be built
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhtibrewal @DashDeipayan @heyrandhir