feat: API to sync in_discord role with discord members and add joined_discord date #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
heyrandhir
suggested changes
May 24, 2023
tracking the test task in a separate issue: #1112 |
|
Please don't mind, but in users.js file line no: 504 why fetching all user data at once ? Why don't we fetch it as paginated or or executing all the paginated users in parallel with Promise.all() ? |
heyrandhir
suggested changes
Jun 7, 2023
heyrandhir
previously approved these changes
Jun 7, 2023
|
Tests are failing? |
yesyash
requested changes
Jun 7, 2023
| @@ -21,6 +21,7 @@ | |||
| router.put("/self/intro", authenticate, userValidator.validateJoinData, users.addUserIntro); | |||
| router.get("/:id/skills", users.getUserSkills); | |||
| router.get("/:id/badges", getUserBadges); | |||
| router.patch("/", authenticate, authorizeRoles([SUPERUSER]), users.nonVerifiedDiscordUsers); | |||
Check failure
Code scanning / CodeQL
Missing rate limiting
RitikJaiswal75
approved these changes
Jun 7, 2023
iamitprakash
requested changes
Jun 7, 2023
iamitprakash
requested changes
Jun 7, 2023
iamitprakash
approved these changes
Jun 7, 2023
yesyash
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create an endpoint to look into the users who have not linked their discord or are not in discord
Coverage
models:
controllers:
THe lines wrote by me are covered