Dev to main sync #1639
Merged
Dev to main sync #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Test : Added test cases for extension request logs * Test : Added test cases for approval/deny * Feat : Creating logs when SU updates the extensionRequest details * Chore : Replaced isDev with dev flag in log test * Refactor : Simplified logics for log generation in dev * Test : Added test case for extension request logs in dev mode * Feat : Prepared API to fetch extensionRequest logs * Bug : Fixed failing test cases * Feat : Added reviewedBy field while fetching latest extension request in dev * Bug : Fixed failing test case for multipleExtensionRequest
* [Live-Site] Add logs for kickout API Signed-off-by: Gurvinder Singh <[email protected]> * [Live-Site] Add logs for kickout API - Integration tests Signed-off-by: Gurvinder Singh <[email protected]> * [Live-Site] Add logs for kickout API - Integration tests for member user Signed-off-by: Gurvinder Singh <[email protected]> --------- Signed-off-by: Gurvinder Singh <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
routes/taskRequests.js
Outdated
|
|
||
| router.get("/", authenticate, authorizeRoles([SUPERUSER]), cacheResponse(), taskRequests.fetchTaskRequests); | ||
| router.get("/", authenticate, authorizeRoles([SUPERUSER]), taskRequests.fetchTaskRequests); |
Check failure
Code scanning / CodeQL
Missing rate limiting High
Developer Name: Joy GuptaPurposeShould return reviewedAt field in response of self extension request. List of PRs going in this SyncPR Number(s): 1639Backend Changes
Is Under Feature Flag
Database changes:
Breaking changes (If your feature is breaking/missing something please mention pending tickets):
Deployment notes:NA Tested in staging
QA Instructions, Screenshots, RecordingsShould return reviewedAt field in response of self extension request. |
Merged
* Req: Update SignIn with Mobile to Handle Query Parameters and Redirect to Mobile App (#1546) (#1562) * Dev to Main Sync (#1594) * Added query parameter orderBy in progress API * Added params defination * Change the condition * adds tests and code changes for updating timestamp for OOO. * handle invalid timestamp case in convertTimestampToUTCStartOrEndOfDay * remove unwanted comment * Added condtion and test to ensure progress only be sorted by date * resolve comments by ajaykrishna and bharati * Enhancement : fetch users who have archived : false (#1595) --------- Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Amit Prakash <[email protected]> Co-authored-by: Jyotsna Mehta <[email protected]> * dev to main sync (#1618) --------- Co-authored-by: Lakshay Manchanda <[email protected]> Co-authored-by: Amit Prakash <[email protected]> Co-authored-by: SHREYA MISHRA <[email protected]> Co-authored-by: Randhir Kumar Singh <[email protected]> Co-authored-by: Shubham Sharma <[email protected]> Co-authored-by: Jyotsna Mehta <[email protected]> Co-authored-by: Prakash Choudhary <[email protected]> Co-authored-by: Shubham Kumar Singh <[email protected]>
Fix conflicts
|
Hi @iamitprakash, you would need to rerun the test case. The test case that has failed sometimes fails without any reason. |
* fix : updates the user status when task is created * chore : changes to before test helper to before each and adds after each in task requests test
iamitprakash
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.