Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds route and controller for missed update user list api #1766

Merged
merged 11 commits into from
Dec 13, 2023

Conversation

Ajeyakrishna-k
Copy link
Contributor

@Ajeyakrishna-k Ajeyakrishna-k commented Dec 9, 2023

Date: 9 Dec 2023

Developer Name: @Ajeyakrishna-k


Issue Ticket Number:-

Description:

Adds a route and controller function which returns discord Id of users who are active with tasks but have not filled in progress updates on task details page.

Docs:

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

Screenshot 2023-12-09 at 5 32 39 PM

@vikhyat187
Copy link
Contributor

@Ajeyakrishna-k can you resolve the merge conflicts please.

@Ajeyakrishna-k Ajeyakrishna-k force-pushed the feat/missed-progress-routes branch from cf06175 to a71b3a6 Compare December 10, 2023 17:13
@Ajeyakrishna-k
Copy link
Contributor Author

@Ajeyakrishna-k can you resolve the merge conflicts please.

Done!

Base automatically changed from feat/missed-progress-updates to develop December 12, 2023 14:08
routes/tasks.js Dismissed Show dismissed Hide dismissed
Copy link
Contributor

@joyguptaa joyguptaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please make sure of raising another PR where you have defined constants in upper and snake case.

@heyrandhir heyrandhir merged commit 61433fc into develop Dec 13, 2023
2 of 3 checks passed
@heyrandhir heyrandhir deleted the feat/missed-progress-routes branch December 13, 2023 23:35
@Ajeyakrishna-k Ajeyakrishna-k mentioned this pull request Dec 17, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants