Flag PATCH users/self route as Deprecated #2196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamitprakash
reviewed
Oct 6, 2024
shubhdevelop
force-pushed
the
deprecate-message
branch
from
0cdc815
to
eb1afad
Compare
yesyash
requested changes
Oct 13, 2024
shubhdevelop
force-pushed
the
deprecate-message
branch
from
88852be
to
7922468
Compare
yesyash
approved these changes
Oct 15, 2024
vinit717
approved these changes
Oct 15, 2024
Achintya-Chatterjee
approved these changes
Oct 15, 2024
|
@shubhdevelop Why was this closed? |
|
got a comment about this from Tejas sir, and work on the new api is on & vikas is doing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 06/10/2024
Developer Name: Shubham Raj
Issue Ticket Number
Closes #2155
The above mentioned issue was related to improving the overall performance of the patch users/self, thought we are either way going to deprecate all the
users/selfroute in accordance with issue #2126, So there is no point wasting effort on something that we are going to deprecate,I'm adding comments, above the controller and the endpoint, as well as update the api contracts documentation
TODO
Documentation Updated?
This PR updates the API Contracts
Note:
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Adds an handy warning in the IDE
Test Coverage
Didn't add any test coverage only modified the previously written one and they all are passing
Additional Notes:
changes done in accordance with solution 3
https://docs.google.com/document/d/1ub9ryFs4qq9m9m5jdOxFAx9VvBPMpOn4-_jDTBaNkJY/edit?tab=t.0