Added AWS config and identity store #2208
Conversation
Dev to Main sync
Dev to Main Sync
Dev to main (Added Pagination in ProfileDiffs API)
|
@vikhyat187 there are no test written along with it. Is there any reason for that? |
Since this needs integration test to test this functionality need to figure out, if we can connect to AWS via github actions. |
| aws: { | ||
| region: "<aws-region>", | ||
| access_key: "<aws-access-key>", | ||
| secret_key: "<aws-secret-key>", | ||
| identity_store_id: "<identity-store-id>", | ||
| }, | ||
|
|
There was a problem hiding this comment.
How to add env keys, please fix this part?
There was a problem hiding this comment.
didn't get this part, do you suggest that the content from production.js cannot be stored in the Github secrets / secrets at the deployment time.
@prakashchoudhary07
There was a problem hiding this comment.
Check how new env keys are added, and update the code accordingly
There was a problem hiding this comment.
sure let me check once.
| const accessKeyId = config.get("aws.access_key") || null; | ||
| const secretAccessKey = config.get("aws.secret_key") || null; | ||
| const region = config.get("aws.region") || "us-east-1"; | ||
| const identityStoreId = config.get("aws.identity_store_id"); |
There was a problem hiding this comment.
Why a null check?
It it doesn't get it it should fail, right?
Date: 8th Oct 24
Developer Name: Vikhyat
Issue Ticket Number
Real-Dev-Squad/todo-action-items#253
Description
Have added the AWS config setup and functions to create user / add user to the IAM group
Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Test Coverage
Screenshot 1
Additional Notes