feat: Integrate userData into Progresses API to reduce redundant calls #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Achintya-Chatterjee
changed the title
|
Please fix the title as commit message is not the title |
vinit717
reviewed
Dec 26, 2024
AnujChhikara
changed the title
…b.com/AnujChhikara/realdev-website-backend into include-userData-in-progress-response
vikasosmium
reviewed
Dec 30, 2024
vikasosmium
reviewed
Dec 30, 2024
vikasosmium
reviewed
Dec 31, 2024
pankajjs
reviewed
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date: 21 Dec 2024
Developer Name: Anuj Chhikara
Issue Ticket Number
Description
This PR introduces a change to include the full
userData(e.g., username, profile picture) alongside the progress data when fetching progress updates. Currently, the backend only returns theuserId, requiring the frontend to make an additional API call to fetch user details. By includinguserDatadirectly with the progress object, we aim to reduce the number of API calls and improve frontend performance and simplicity.Documentation Updated?
Under Feature Flag
Database Changes
Breaking Changes
Development Tested?
Screenshots
Screenshot 1
Without dev flag
With dev flag
Test Coverage
Screenshot 1
Additional Notes