Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: skip users having approved onboarding extension when applying groupOnboarding31d+ role #2330

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

pankajjs
Copy link
Contributor

@pankajjs pankajjs commented Jan 2, 2025

Date: 2 Jan, 2025

Developer Name: @pankajjs


Issue Ticket Number

Description

  • The PR contains the fix and tests both.
  • This PR filters onboarding users and skip who have a valid approved extension request and then apply the groupOnboarding31d+ role.
  • The changes are not behind feature flag as the /discord-actions/group-onboarding-31d-plus api is invoked by cron job after every 30 minutes. So, there is not any user's control over feature flag, I have not made the changes behind feature flag.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Working Videos
  • Example when cron job run and apply groupOnboarding31d+ role.
fix1.mp4
  • Example when cron job run and skip the user who has valid approved extension request.
fix2.mp4

Test Coverage

Screenshots Screenshot 2025-01-02 at 1 02 36 PM Screenshot 2025-01-02 at 1 03 57 PM Screenshot 2025-01-02 at 1 05 11 PM Screenshot 2025-01-02 at 1 05 58 PM Screenshot 2025-01-02 at 12 58 26 PM

Additional Notes

@pankajjs pankajjs force-pushed the fix/skip-onboarding-user branch from 8c93d7b to 9643feb Compare January 5, 2025 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature : Extend Onboarding Override for Discord Server
1 participant