Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : change node version to 22.10.0 #2354

Merged
merged 7 commits into from
Jan 18, 2025
Merged

fix : change node version to 22.10.0 #2354

merged 7 commits into from
Jan 18, 2025

Conversation

vikasosmium
Copy link
Contributor

@vikasosmium vikasosmium commented Jan 18, 2025 •
edited by Achintya-Chatterjee
Loading

Date: 19-Jan-2025

Developer Name: @vikasosmium

Issue Ticket Number

Description

This PR updates the node version to fix the railway deployment issue.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1

Test Coverage

Unit Test 
=============================== Coverage summary ===============================
Statements   : 68.17% ( 5252/7704 )
Branches     : 56.38% ( [1355](https://github.com/Real-Dev-Squad/website-backend/actions/runs/12815303863/job/35733691542?pr=2350#step:5:1356)/2403 )
Functions    : 64.74% ( 819/1265 )
Lines        : 68.63% ( 4885/7117 )
================================================================================
Integration Test 
=============================== Coverage summary ===============================
Statements   : 74.35% ( 8189/11014 )
Branches     : 63.59% ( 2369/3725 )
Functions    : 74.82% ( 1293/1728 )
Lines        : 74.28% ( 7558/10174 )
================================================================================
✔  Script exited successfully (code 0)
i  emulators: Shutting down emulators.
i  firestore: Stopping Firestore Emulator
i  hub: Stopping emulator hub
i  logging: Stopping Logging Emulator
Done in 150.87s.

Additional Notes

@vikasosmium vikasosmium self-assigned this Jan 18, 2025
yesyash
yesyash previously approved these changes Jan 18, 2025
View reviewed changes
@Achintya-Chatterjee Achintya-Chatterjee changed the title Fix/node version update update/node version Jan 18, 2025
@yesyash yesyash dismissed their stale review January 18, 2025 19:49
  • improper pr title
@yesyash yesyash changed the title update/node version fix : change node version to 22.10.0 Jan 18, 2025
@yesyash yesyash merged commit 6c5a1df into Real-Dev-Squad:develop Jan 18, 2025
3 checks passed
yesyash pushed a commit that referenced this pull request Jan 18, 2025
@vikasosmium @yesyash
fix : change node version to 22.10.0 (#2354)
f2b27db 
* node version update to v22.x

* yml node version update

* node version update

* fixed node version for railway
@vikasosmium vikasosmium added dependencies Pull requests that update a dependency file backend labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesyash yesyash yesyash approved these changes

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee approved these changes

@iamitprakash iamitprakash Awaiting requested review from iamitprakash

Assignees

@vikasosmium vikasosmium

Labels
backend dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix node version on staging
3 participants
@vikasosmium @Achintya-Chatterjee @yesyash