Adds routes for Skills API #650
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ankushdharkar can you review it? |
Mir-SA
force-pushed
the
skills-api
branch
2 times, most recently
from
f8a3c27
to
77eceb4
Compare
rohan09-raj
reviewed
Aug 14, 2022
rohan09-raj
reviewed
Aug 14, 2022
rohan09-raj
reviewed
Aug 14, 2022
rohan09-raj
reviewed
Aug 14, 2022
rohan09-raj
reviewed
Aug 14, 2022
rohan09-raj
reviewed
Aug 14, 2022
rohan09-raj
reviewed
Aug 14, 2022
rohan09-raj
reviewed
Aug 14, 2022
rohan09-raj
reviewed
Aug 14, 2022
rohan09-raj
reviewed
Aug 14, 2022
Mir-SA
force-pushed
the
skills-api
branch
2 times, most recently
from
123b24d
to
14979c5
Compare
samarpan1738
requested changes
Aug 19, 2022
Mir-SA
requested review from
samarpan1738
and removed request for
ankushdharkar and
rohan09-raj
ankushdharkar
requested changes
Aug 24, 2022
prakashchoudhary07
requested changes
Aug 29, 2022
Comment on lines
+303
to
+306
| const { skillName } = req.params; | ||
| const skillWithoutSpecialChar = checkDashUnderscore.test(skillName) | ||
| ? skillName.replace(checkDashUnderscore, " ") | ||
| : skillName; |
There was a problem hiding this comment.
If there is some error here, how is that handled?
| */ | ||
| async function awardSkill(skillData, userName) { | ||
| try { | ||
| const skillSnapshot = await skillsCollection.add(skillData); |
There was a problem hiding this comment.
Won't this create multiple records for the same skills?
|
Closing this as this feature is being built as a stand-alone product, in Skill-tree https://github.com/Real-Dev-Squad/skill-tree-frontend/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API Contract and Data Model should be finalised before moving ahead with this feature
Description
This feature adds routes, controllers, and models for these endpoints
/skills/:username/skills/skills/:username/users/skill/:skillNameThis feature will help fetch the skills of users dynamically from the backend instead of current mock data on members site. These skill/s will be given to the user from the dashboard site
Closes #455