Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social url issue fix #563

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

DevSoni2022
Copy link
Contributor

@DevSoni2022 DevSoni2022 commented Oct 15, 2023

What is the change?

When user updating social URL with complete HTTPS request it's get redirect on wrong page

Provide a small description of what did you change and provide the reference to the issue ticket.
I have checked if Id contain HTTP or HTTPS ,will abstract user name

Is it bug?

Yes

  • Steps to repro
  • Expected
  • Actual

*Dev Tested?

  • Yes
  • No

*Tested on:

Screenshot 2023-10-15 141445

Platforms

  • Web

Browsers

  • Chrome
  • Safari
  • Firefox

Before / After Change Screenshots

Before

For visual or interaction ch

Screen.Recording.15-10-2023.14-28-25.mp4

. Can be video / screenshot.
After changes

Screen.Recording.15-10-2023.20-24-21.mp4

@vercel
Copy link

vercel bot commented Oct 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
members-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 11:09am
website-members ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 11:09am

Copy link
Contributor

@anishpawaskar anishpawaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can change CheckId to camel case like this checkId

@DevSoni2022
Copy link
Contributor Author

Can change CheckId to camel case like this checkId

Resolved

Copy link
Contributor

@anishpawaskar anishpawaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iamitprakash iamitprakash self-requested a review October 16, 2023 18:43
@iamitprakash iamitprakash merged commit da145ac into Real-Dev-Squad:develop Oct 16, 2023
6 checks passed
@shubhamjaintech shubhamjaintech mentioned this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants