added feature flag in select option

Real-Dev-Squad · Oct 30, 2023 · b03b29b · b03b29b
1 parent 46c0e15
commit b03b29b
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 8 deletions.
diff --git a/app/components/task/holder.hbs b/app/components/task/holder.hbs
@@ -41,13 +41,27 @@
         >
           {{#each this.availabletaskStatusList as |taskStatus|}}
             {{#if (not-eq taskStatus.key this.TASK_KEYS.ALL)}}
-              <option
-                data-test-dropdown-option={{taskStatus.displayLabel}}
-                value={{taskStatus.key}}
-                selected={{eq taskStatus.key this.status}}
-              >
-                {{taskStatus.displayLabel}}
-              </option>
+              {{#if @dev}}
+                {{#if (not-eq taskStatus.key this.TASK_KEYS.COMPLETED)}}
+                  <option
+                    data-test-dropdown-option={{taskStatus.displayLabel}}
+                    value={{taskStatus.key}}
+                    selected={{eq taskStatus.key this.status}}
+                  >
+                    {{taskStatus.displayLabel}}
+                  </option>
+                {{/if}}
+              {{else}}
+                {{#if (not-eq taskStatus.key this.TASK_KEYS.DONE)}}
+                  <option
+                    data-test-dropdown-option={{taskStatus.displayLabel}}
+                    value={{taskStatus.key}}
+                    selected={{eq taskStatus.key this.status}}
+                  >
+                    {{taskStatus.displayLabel}}
+                  </option>
+                {{/if}}
+              {{/if}}
             {{/if}}
           {{/each}}
         </select>

diff --git a/tests/integration/components/tasks/holder-test.js b/tests/integration/components/tasks/holder-test.js
@@ -199,6 +199,41 @@ module('Integration | Component | Tasks Holder', function (hooks) {
     @disabled={{this.disabled}}
   />`);
 
+    assert
+      .dom('[data-test-task-status-select]')
+      .hasValue(TASK_KEYS.IN_PROGRESS);
+
+    await select('[data-test-task-status-select]', TASK_KEYS.COMPLETED);
+
+    assert
+      .dom('[data-test-task-status-select]')
+      .hasValue(TASK_KEYS.IN_PROGRESS);
+  });
+
+  test('Verify values of task status upon api failures under feature flag', async function (assert) {
+    const testTask = tasksData[3];
+    testTask.status = TASK_KEYS.IN_PROGRESS;
+
+    this.set('task', testTask);
+    this.set('mock', () => {});
+    this.set('onTaskUpdate', (taskId, error) => {
+      error();
+    });
+    this.set('isLoading', false);
+    this.set('disabled', false);
+    this.set('defaultType', DEFAULT_TASK_TYPE);
+    this.set('dev', true);
+
+    await render(hbs`<Task::Holder
+    @task={{this.task}}
+    @onTaskChange={{this.mock}}
+    @onStausChange={{this.mock}}
+    @onTaskUpdate={{this.onTaskUpdate}}
+    @userSelectedTask={{this.defaultType}}
+    @disabled={{this.disabled}}
+    @dev={{this.dev}}
+  />`);
+
     assert
       .dom('[data-test-task-status-select]')
       .hasValue(TASK_KEYS.IN_PROGRESS);
@@ -243,12 +278,13 @@ module('Integration | Component | Tasks Holder', function (hooks) {
     assert.equal(onTaskUpdateCalled, 1, 'onTaskUpdate should be called once');
   });
 
-  test('Render Task holder and check whether it has select tag with option DONE', async function (assert) {
+  test('Render Task holder and check whether it has select tag with option DONE under feature flag', async function (assert) {
     this.set('task', tasksData[3]);
     this.set('mock', () => {});
     this.set('isLoading', false);
     this.set('disabled', false);
     this.set('defaultType', DEFAULT_TASK_TYPE);
+    this.set('dev', true);
 
     await render(hbs`<Task::Holder
     @task={{this.task}} 
@@ -258,6 +294,7 @@ module('Integration | Component | Tasks Holder', function (hooks) {
     @isLoading={{this.isLoading}} 
     @userSelectedTask={{this.defaultType}} 
     @disabled={{this.disabled}}
+    @dev={{this.dev}}
   />`);
 
     assert.dom('[data-test-task-status-select]').exists();