resolved the PR comments

Real-Dev-Squad · Nov 2, 2023 · fdcaad1 · fdcaad1
1 parent 5fc0768
commit fdcaad1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 4 deletions.
diff --git a/app/components/task/holder.hbs b/app/components/task/holder.hbs
@@ -37,7 +37,7 @@
         data-test-task-status-select
         id='task-update'
         {{on 'change' this.onStatusChange}}
-        disabled={{eq @task.status 'DONE'}}
+        disabled={{eq @task.status this.TASK_KEYS.DONE}}
       >
         {{#each this.removedTaskStatus as |taskStatus|}}
           <option
@@ -52,7 +52,7 @@
     </div>
 
     {{#if @dev}}
-      {{#if (not-eq @task.status 'DONE')}}
+      {{#if (not-eq @task.status this.TASK_KEYS.DONE)}}
         <button
           class='task-card__extensionForm-button'
           data-test-task-extensionForm-button

diff --git a/app/components/task/holder.js b/app/components/task/holder.js
@@ -9,7 +9,6 @@ export default class TasksHolderComponent extends Component {
   @tracked status = this.args.task.status;
   @tracked extensionFormOpened = false;
   @tracked isLoading = false;
-  @tracked disable = false;
   queryParams = ['dev'];
 
   TASK_KEYS = TASK_KEYS;

diff --git a/app/constants/tasks.js b/app/constants/tasks.js
@@ -135,7 +135,7 @@ const TABS_TASK_STATUS_LIST = [
   },
   {
     displayLabel: 'Done',
-    key: COMPLETED,
+    key: DONE,
   },
   {
     displayLabel: 'Verified',