feat:added location field #270
Conversation
| <Input | ||
| <div class="field"> | ||
| <Input |
There was a problem hiding this comment.
Do we need this div field for each input, can we put a separate if statement which check if the field is location, and then renders a different form input which is inside a div and contains a button
There was a problem hiding this comment.
@vinayak-trivedi If we are doing this it is breaking whole form css of the form
|
one more thing can we increase the margin left and right for the button |
You mean |
yes padding. thanks for pointing it out rajat |
|
one more thing @aakankshadhurandhar you should also send this data with other data to backend also |
|
@aakankshadhurandhar we also need to give the user the suggestion of the location as shown in the ss below, and we will store the coordinates of that location, we will be using geocoding API for that, please have a look at that
|
|
@vinayak-trivedi I think do you mean integrating of geolocation API with the update location button? I think we must do this in a separate PR. |
yes makes sense, ensure one thing that even if it goes to prod, the user do not get to fill this location field for now, it should only be visible if dev=true |
…ite-my into feature/location-field
I don't think that this is being addressed here, we need to show this field only if we have |
|
One more change that is required is that the user should only see the update location button if he has already filled the location |
| @@ -9,6 +10,13 @@ | |||
| @class={{if @showError 'input errorBorder' 'input'}} | |||
| {{on 'input' (fn this.inputFieldChanged)}} | |||
| /> | |||
| {{#if @buttonupload }} | |||
| <button class="upload" type="submit">update location</button> | |||
There was a problem hiding this comment.
update location -> Update, as the user already knows they are updating the location from the Input Label
|
|
||
|
|
There was a problem hiding this comment.
Can we please remove these extra spaces?
| label: 'Location', | ||
| type: 'text', | ||
| placeholder: 'bangalore', | ||
| buttonupload: true, |
There was a problem hiding this comment.
Can we please follow CamelCase here?
| @@ -28,6 +28,10 @@ h1 { | |||
| flex-direction: column; | |||
| justify-content: center; | |||
| align-items: flex-start; | |||
| position: relative; | |||
| } | |||
| .field_right{ | |||
There was a problem hiding this comment.
Can we please put a single line space after the CSS block?
| .container { | ||
| width: 100%; | ||
| color: #666; |
There was a problem hiding this comment.
Can we please use CSS variables here?
Please follow the pattern in variables.css file
| .user-details__heading { | ||
| font-size: 2rem; | ||
| color: black; |
There was a problem hiding this comment.
| width: 100%; | ||
| border-radius: 10px; | ||
| border: 2px solid darkgray; |
There was a problem hiding this comment.
| border-radius: 10px; | ||
| outline: none; | ||
| background-color: green; |
There was a problem hiding this comment.
| outline: none; | ||
| background-color: green; | ||
| color: white; |
There was a problem hiding this comment.
|
|
||
| .signup-action__btn button.btn-disabled { | ||
| background: #ccc; |
There was a problem hiding this comment.
| right: 0; | ||
| height: 100%; | ||
| color: blue; |
There was a problem hiding this comment.
| @@ -16,7 +16,10 @@ | |||
| @helpMsg={{field.helpMsg}} | |||
| @onChange={{this.handleFieldChange}} | |||
| @validator={{field.validator}} | |||
| @disabled={{field.disabled}} /> | |||
| @disabled={{field.disabled}} | |||
| @buttonupload={{field.buttonupload}} | |||
There was a problem hiding this comment.
Can we please follow CamelCase here?
Fixes : #257
