Dev to Main sync #504
Merged
Dev to Main sync #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* create button to allow multiple extensions * add test for multiple extension request form * fix style * fix style * fix style and refactor component * refactor form and details and fix styles * fix test cases * final fix
✅ Deploy Preview for staging-my ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
prakashchoudhary07
changed the title
kotesh-arya
previously approved these changes
Oct 16, 2023
Ajeyakrishna-k
previously approved these changes
Oct 18, 2023
…either approved or denied (#503) * Feat : Added reviewed by log in extension status modal * Test : Added test cases to verify review log
Deploying with
|
| Latest commit: |
0d93af1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f84e8c47.my-rds.pages.dev |
| Branch Preview URL: | https://develop.my-rds.pages.dev |
Developer Name: Joy GuptaPR Number(s): 504Issue Ticket Number:Frontend Changes
Is Under Feature Flag
Database changes:
Breaking changes (If your feature is breaking/missing something please mention pending tickets):
Deployment notes:NA Tested in staging
List of PRs going in this SyncProposal DocQA Instructions, Screenshots, Recordings1. The extension request modal should contain reviewed by text in dev mode if the API response contains reviewedBy field 2. The extension request modal should not contain reviewedBy field without dev mode enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Name: @MayurLund
PR Number(s):
Issue Ticket Number:
Backend changes
Frontend Changes
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Deployment notes(Any special instructions for the deployment)
Tested in staging
Proof of staging:
Verified the staging environment with the 'dev' flag, and everything's in order as per the issue ticket. I've provided post-update images for the frontend and dashboard. Additionally, I successfully initiated multiple extension requests; the latest one (No. 3) is currently pending. This pending status is preventing the creation of a new request. Here's a snapshot illustrating the pending request: