-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Open RDS app from my-site #506
Conversation
✅ Deploy Preview for staging-my ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Can you please add video of your changes? |
Added |
can you please add a clear video, of the feature yo are trying to build is not clear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
write proper tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added please check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the colors used here are same with RDS design colors?
Also, pr description can be improved. Please add test coverage.
Tests are failing due to lint issues |
If app is not installed and when user click okay then it is not possible that it is directly redirect to that rds app to installed because in video i seen it redirect to github app. if you don't know about above please ask once @shreya-mishra |
For demo purpose I have added github url as currently RDS app is not published in future it will be replace with RDS App. |
Please add mobile video here only without google drive link, also put this feature under feature flag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work Dhruv...can you please check some of my comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@Pratiyushkumar I have added clear video with description please have a look. |
Added |
Resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue #501
Description:
This PR contains feature of open RDS mobile app through dialog whenever user open it in mobile browser. Note dialog will not open in desktop browser.
Is Development Tested?
1. Screen Recoding: Mobile
In case of mobile dialog will open and user can open app On click of okay if user has installed RDS it will open RDS app otherwise it will redirect to playstore for RDS app.
Mobile.Recording.mov
2. Screen Recoding: Desktop
In this case dialog will not open.
Screen.Recording.2023-10-28.at.6.41.59.PM.mov
Test Coverage