Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] - Task Card Enhacement (milestone-1) #510

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

Pratiyushkumar
Copy link

@Pratiyushkumar Pratiyushkumar commented Oct 28, 2023

Date: 11-02-2023

Developer Name: Pratiyush

Issue

Description

UI changes are done where Extension Status button has been renamed by Request Extension. After the task is 100% completed and the status is Completed then the Extension Request button should not be visible. Some of unwanted statuses which were not in use have been removed like - smoke Testing, sanity check, Regression Check, Released, verified, Needs Review, Approved and feature is put behind the feature flag.

Is Development Tested?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Deployment notes
Any special instructions for the deployment (none)

Before Changes

bandicam.2023-11-02.12-16-59-900.mp4

After changes

bandicam.2023-11-02.06-59-13-844.mp4
bandicam.2023-11-02.23-25-00-436.mp4

image

Test Coverage

image

image

@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit edf6b54
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/655ab272a3cd05000821f0f9
😎 Deploy Preview https://deploy-preview-510--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pratiyushkumar Pratiyushkumar changed the title Fix/milestone 1 [Fix] - Task Card Enhacement (milestone-1) Oct 28, 2023
@Pratiyushkumar Pratiyushkumar self-assigned this Oct 29, 2023
@shubhamsinghbundela
Copy link
Contributor

shubhamsinghbundela commented Oct 30, 2023

I think Once status change to completed then don't allow to change other status from select tag

@Pratiyushkumar
Copy link
Author

I think Once status change to completed then don't allow to change other status from select tab

why so??

@shubhamsinghbundela
Copy link
Contributor

shubhamsinghbundela commented Oct 30, 2023

Completed means DONE, In rds We all know done defination i.e. our changes is in prod.
if you have confusion please discuss once with @iamitprakash @ankushdharkar

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is In_progess color is yellow ..?

@iamitprakash
Copy link
Member

I think Once status change to completed then don't allow to change other status from select tag

yes, true @shubhamsigdar1 @Pratiyushkumar

@iamitprakash
Copy link
Member

I think Once status change to completed then don't allow to change other status from select tab

why so??

once task has been marked completed, can you please explain the reason to put back into in-progress

@Pratiyushkumar
Copy link
Author

as been marked completed, can you please explain the reason to put back into in-progres

since the start date is not mentioned hence it shows color yellow

@Pratiyushkumar
Copy link
Author

I think Once status change to completed then don't allow to change other status from select tag

fixed

Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't understand the commit message and the changes you did :)
image

@Ajeyakrishna-k
Copy link
Contributor

  • I think the card height should not change once its completed.
  • Why is the status COMPLETED before IN REVIEW?
  • I also think we should still show the status as completed on the card and disable it instead of removing it from the card.

@iamitprakash
Copy link
Member

as been marked completed, can you please explain the reason to put back into in-progres

since the start date is not mentioned hence it shows color yellow

can you pass me the documentation link

@Pratiyushkumar
Copy link
Author

as been marked completed, can you please explain the reason to put back into in-progres

since the start date is not mentioned hence it shows color yellow

can you pass me the documentation link

#497
Here it is

@Pratiyushkumar
Copy link
Author

  • I think the card height should not change once its completed.
  • Why is the status COMPLETED before IN REVIEW?
  • I also think we should still show the status as completed on the card and disable it instead of removing it from the card.

done

app/components/task/holder.js Outdated Show resolved Hide resolved
app/components/task/holder.js Outdated Show resolved Hide resolved
app/components/task/holder.js Outdated Show resolved Hide resolved
app/components/task-tabs.hbs Outdated Show resolved Hide resolved
app/constants/tasks.js Outdated Show resolved Hide resolved
app/components/task/holder.hbs Outdated Show resolved Hide resolved
app/components/task/holder.hbs Outdated Show resolved Hide resolved
Ajeyakrishna-k
Ajeyakrishna-k previously approved these changes Nov 2, 2023
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add proper details

Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is UI changes demo would be needed for approval

@Pratiyushkumar
Copy link
Author

Please add proper details

what kind of details is missing, please guide me I will mention it

@Pratiyushkumar
Copy link
Author

As this is UI changes demo would be needed for approval

when can I present DEMO

sahsisunny
sahsisunny previously approved these changes Nov 2, 2023
Copy link
Member

@iamitprakash iamitprakash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after changing status to done, why dropdown is enable or showing down array...?

@Pratiyushkumar
Copy link
Author

after changing status to done, why dropdown is enable or showing down array...?

Drop down button gets disabled, user cannot update status again as per @Ajeyakrishna-k review comment.

@Pratiyushkumar
Copy link
Author

after changing status to done, why dropdown is enable or showing down array...?

done the changes

app/components/task-tabs.hbs Outdated Show resolved Hide resolved
app/components/task/holder.hbs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants