Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed feature flag for cancel OOO #517

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Removed feature flag for cancel OOO #517

merged 3 commits into from
Nov 7, 2023

Conversation

PeeyushPrashant
Copy link
Contributor

@PeeyushPrashant PeeyushPrashant commented Nov 5, 2023 •
edited
Loading

Issue Closes #516

What is the change?

  • Removed dev=true prop being passed to UserStatus component from the template
  • Moved the cancel OOO button outside the if condition which checks the dev mode currently.
  • Merged two seperate test case written to handle cases with & without feature flag in a single test case
  • feature outside feature flag

Is Development Tested?

  • Yes
  • No

Before & After Change

screen-capture.webm

Test

screen-capture.1.webm

Stats

Screenshot 2023-11-06 081715
Screenshot 2023-11-06 082023

@netlify Netlify
Copy link

netlify bot commented Nov 5, 2023 •
edited
Loading

✅ Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit e48b02d
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/6549092f344e5c00087ba019
😎 Deploy Preview https://deploy-preview-517--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

heyrandhir
heyrandhir reviewed Nov 5, 2023
View reviewed changes
Copy link
Contributor

@heyrandhir heyrandhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the test stats just to be on the safer side.

@PeeyushPrashant
Copy link
Contributor Author

Sure, I have added the stats now @heyrandhir.

heyrandhir
heyrandhir previously approved these changes Nov 6, 2023
View reviewed changes
@shubhamsinghbundela shubhamsinghbundela merged commit ee53203 into develop Nov 7, 2023
5 checks passed
@shubhamsinghbundela shubhamsinghbundela deleted the featureflag_removal branch November 7, 2023 11:18
@PeeyushPrashant PeeyushPrashant mentioned this pull request Nov 7, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shubhamsinghbundela shubhamsinghbundela shubhamsinghbundela approved these changes

@heyrandhir heyrandhir heyrandhir approved these changes

@ajoykumardas12 ajoykumardas12 ajoykumardas12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove feature flag for cancel OOO button
4 participants
@PeeyushPrashant @ajoykumardas12 @heyrandhir @shubhamsinghbundela