Signup fix #14
Open
Signup fix #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neha
suggested changes
Jun 21, 2022
| @@ -1,3 +1,3 @@ | |||
| const signupPageTitle = /Sign Up/; | |||
There was a problem hiding this comment.
Please follow the UPPERCASE for the const name and separated by the _
| @@ -12,6 +12,6 @@ | |||
| "jest": "^27.1.0" | |||
| }, | |||
| "scripts": { | |||
| "test": "jest" | |||
| "test": "jest sign-up" | |||
There was a problem hiding this comment.
The settings in the package.json should be targeted to a folder-test rather than just one file.
| describe("New user navigates in the page", () => { | ||
| test("New user sees a sign up page", async () => { | ||
| describe('New user navigates in the page', () => { | ||
| // const response = { |
| await page.waitForSelector('button#js-oauth-authorize-btn'); | ||
| } catch (err) { | ||
| console.log( | ||
| 'The test user credentials are wrong or your test account is already has RDS as an OAuth application.', |
| const pageTitle = await page.title(); | ||
| expect(pageTitle).toMatch(signupPageTitle); | ||
| }); | ||
| //For mocking github api -->> | ||
| // page.on('request', (request) => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrote a test case for 401 response.