Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored navbar #238

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

refactored navbar #238

wants to merge 8 commits into from

Conversation

rupal-2505
Copy link

@rupal-2505 rupal-2505 commented Oct 5, 2022 •
edited
Loading

Issue

#235

Current status

Currently , when user scroll-down the RDS website, the navbar is scrolled down .

Screenshot (75)

What is the change?

Navbar is fixed .Will not scroll with the page.

Video for reference

Navbar.mp4

@Real-Dev-Squad Real-Dev-Squad deleted a comment from netlify bot Oct 6, 2022
@Real-Dev-Squad Real-Dev-Squad deleted a comment from netlify bot Oct 6, 2022
RitikJaiswal75
RitikJaiswal75 reviewed Oct 8, 2022
View reviewed changes
Copy link

@RitikJaiswal75 RitikJaiswal75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put a proper video of the changes

RitikJaiswal75
RitikJaiswal75 reviewed Oct 8, 2022
View reviewed changes
Copy link

@RitikJaiswal75 RitikJaiswal75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rupal-2505 In many places i can see that you have changed lot of styling related to width margins and padding, I understand the top margin part where you want the navbar to look sticky to the top but other places do not really make sense for this PR.

index.html Show resolved Hide resolved
RitikJaiswal75
RitikJaiswal75 suggested changes Oct 8, 2022
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@rupal-2505 rupal-2505 closed this Oct 11, 2022
@rupal-2505 rupal-2505 deleted the refactor/making-navbar-sticky branch October 11, 2022 16:43
@rupal-2505 rupal-2505 restored the refactor/making-navbar-sticky branch October 11, 2022 16:43
@rupal-2505
Copy link
Author

rupal-2505 commented Oct 11, 2022 •
edited
Loading

@rupal-2505 In many places i can see that you have changed lot of styling related to width margins and padding, I understand the top margin part where you want the navbar to look sticky to the top but other places do not really make sense for this PR.

@RitikJaiswal75 I'have only changed the margins and paddings where it's necessary to make the navbar sticky. i will look into it again and try to remove unnecessary ones.

@rupal-2505 rupal-2505 reopened this Oct 11, 2022
@rupal-2505
Copy link
Author

Please put a proper video of the changes

@RitikJaiswal75 Added video for reference.

@rupal-2505 rupal-2505 changed the title refactoring navbar sticky refactored navbar Oct 20, 2022
@ankushdharkar ankushdharkar requested a review from Maheima October 20, 2022 16:05
@ankushdharkar ankushdharkar self-requested a review October 20, 2022 16:05
RitikJaiswal75
RitikJaiswal75 suggested changes Oct 20, 2022
View reviewed changes
css/index.css
header {
position: sticky;
top: 0;
background-color: #1d1283;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use a css variable here

css/navbar-linked-pages.css
@@ -1,5 +1,8 @@
nav {
font-weight: 700;
position: sticky;
top: 0;
background-color: #1d1283;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use css variable

css/navbar.css
@@ -1,6 +1,9 @@
nav {
font-family: 'roboto';
font-weight: 700;
position: sticky;
top: 0;
background-color: #1d1283;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

css variable please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RitikJaiswal75 RitikJaiswal75 RitikJaiswal75 requested changes

@Maheima Maheima Awaiting requested review from Maheima

@ankushdharkar ankushdharkar Awaiting requested review from ankushdharkar

At least 1 approving review is required to merge this pull request.

Assignees

@ankushdharkar ankushdharkar

@rupal-2505 rupal-2505

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rupal-2505 @RitikJaiswal75 @ankushdharkar