Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role option for existing user #541

Open
wants to merge 7 commits into
base: archived-develop
Choose a base branch
from

Conversation

shubhamsinghbundela
Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela commented Jul 28, 2023

close

What is the change?

  1. made a popup on www.realdevsquad.com
  2. popup contain UI to select role by existing user
  3. made changes in file
    • js/goto.js
    • js/index.js
    • css/main.css
    • index.html

After Change Screenshots

vXB2Z9Hg4A.mp4

Responsiveness

chrome_0T48A8Nggx.mp4

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jul 28, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c059199
Status: ✅  Deploy successful!
Preview URL: https://a4639c91.www-rds.pages.dev
Branch Preview URL: https://fature-popup.www-rds.pages.dev

View logs

@shubhamsinghbundela shubhamsinghbundela self-assigned this Jul 28, 2023
index.html Outdated Show resolved Hide resolved
index.html Outdated
name="productmanager"
class="checkbox-input"
/>
Product Manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with changes. can you please check latest commit message

js/goto.js Show resolved Hide resolved
js/index.js Outdated
submitButton.disabled = false;
popupContainer.style.display = 'none';
} else {
//have to add toast here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

till then you can show some alert or something

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done with changes. can you please check latest commit message

@shubhamsinghbundela shubhamsinghbundela added feature task Big features that have to be built UI labels Jul 28, 2023
Copy link
Contributor

@sahsisunny sahsisunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhamsigdar1 this PR needs some necessary and small changes so i want to addressed those issues.

css/main.css Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
js/goto.js Show resolved Hide resolved
js/index.js Show resolved Hide resolved
js/index.js Outdated Show resolved Hide resolved
js/index.js Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
css/main.css Show resolved Hide resolved
js/index.js Show resolved Hide resolved
js/index.js Show resolved Hide resolved
js/index.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature task Big features that have to be built UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants