Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Live-Site] - make sidebar collapsible #720

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Pratiyushkumar
Copy link
Contributor

@Pratiyushkumar Pratiyushkumar commented Oct 28, 2023

Issue

What is the change?

Currently, in desktop mode, the sidebar which contains a list of participants who join the live streaming, sidebar should be collapsible so that the video player screen can be enlarged

Is Development Tested?

  • Yes
  • No

Before / After Change Screenshots

bandicam.2023-10-28.20-47-46-331.mp4

@Pratiyushkumar Pratiyushkumar self-assigned this Oct 28, 2023
@Pratiyushkumar Pratiyushkumar changed the title sidebar is collapsing on click of expand button [Live-Site] - make sidebar collapsible Oct 28, 2023
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 29, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 29f5151
Status: ✅  Deploy successful!
Preview URL: https://800e1809.www-rds.pages.dev
Branch Preview URL: https://feature-collapsiblebar.www-rds.pages.dev

View logs

@satyam73
Copy link
Member

image

Live staging site

image

Your changes

In this there's space coming from right to the sidebar, please fix this.

@satyam73
Copy link
Member

Also for mobile screen we can hide the full screen toggle button, since it's not needed

Copy link
Member

@satyam73 satyam73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please write the tests for the classes getting update on toggle?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants