Refactor Join Steps #840
Open
Refactor Join Steps #840
+69
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
9373d1c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f326003.www-rds.pages.dev |
| Branch Preview URL: | https://refactor-join-steps.www-rds.pages.dev |
satyam73
requested changes
Jan 23, 2024
| @@ -15,7 +15,7 @@ | |||
| {{#if this.errorMessage.whyRds}} | |||
| <div class='error__message'>{{this.errorMessage.whyRds}}</div> | |||
| {{/if}} | |||
|
|
|||
| <div class="input-box__hour"> | |||
There was a problem hiding this comment.
Let's make the class more generic
Suggested change
| <div class="input-box__hour"> | |
| <div class="input-box__time"> |
| assert.dom('[data-test-onboarding-card-modal]').exists(); | ||
| assert.dom('[data-test-error-message]').doesNotExist(); |
There was a problem hiding this comment.
is the test for exist case already written?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
18-01-2024Developer Name:
vinitIssue Ticket Number:-
Description:
In this pr join steps refactoration is done including submit btn to disable if previous any filled is not filled
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
Follow-up issue