setup: add docker file #930

satyam73 · 2024-09-04T05:06:45Z

Date: to be filled

Developer Name: Satyam Bajpai

Issue Ticket Number:-

Description:

Add description of the PR here

Is Under Feature Flag

Yes
No

Database changes

Yes
No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

Yes
No

Is Development Tested?

Yes
No

Tested in staging?

Yes
No

Add relevant Screenshot below ( e.g test coverage etc. )

cloudflare-workers-and-pages · 2024-09-04T05:09:42Z

Deploying www-rds with Cloudflare Pages

Latest commit:	`43a5ed7`
Status:	✅ Deploy successful!
Preview URL:	https://1cea5511.www-rds.pages.dev
Branch Preview URL:	https://setup-dockerize-app.www-rds.pages.dev

View logs

satyam73 · 2024-09-06T20:39:50Z

Currently the app is not running in docker container(in terminal I am getting correct output) and when I am running normally(means without docker) it is working fine and I can see the app running on the respective port.

For docker

Checkout to this branch
Run docker build . command inside website-www directory. Wait till docker image is creating.
After it gets created run docker images to see the image, copy the id of latest image(which got build just now)
Run the image with command docker run <IMAGE_ID>
Check that it will spin up the fastboot workers and app will be served in port 5000(When going to http://localhost:5000 I am not seeing running app that's the actual issue whereas when I am running without docker as steps mentioned below I am able to see the app running on http://localhost:5000)

For without docker

Checkout to this branch
Make sure you have done yarn install
Run yarn build to build the app
After build succeeds run node fastboot-server.js
Check that it will spin up the fastboot workers and app will be served in port 5000

Update

The above issue is resolved more context below

So the issue was I was using the command docker run <IMAGE_ID>

So it was correctly not mapping the port of my machine and the docker machine

By using the command docker run -p <host_port>:<container_port> <image_name> it started to map the container port my host port and everything worked fine, I can see my app running in the browser.

Updated steps to run docker

Run docker build . to build image.
After image gets created run docker images to see the images, copy the id of latest image(which got build just now)
Run the image with command docker run -p 5000:5000 <IMAGE_ID>
Go to http://localhost:5000/ and we will see our app running.

prakashchoudhary07 · 2024-09-11T18:54:18Z

app/constants/urls.js

+    // API_BACKEND: `${SCHEME}api.${DOMAIN}`,hostWhitelist
+
+    API_BACKEND: `http://localhost:3000`,
+


Yes was testing, forgot to remove, thanks for pointing it out.
Update it now

prakashchoudhary07 · 2024-09-11T18:54:40Z

fastboot-server.js

+// import FastBootAppServer from 'fastboot-app-server';

+// eslint-disable-next-line no-undef
+const FastBootAppServer = require('fastboot-app-server');


Why are we not using commonjs? and using require?

I was facing error in other files while I was using es6 code, so that's why instead of changing them I changed this one only

prakashchoudhary07 · 2024-09-11T19:01:35Z

Dockerfile

@@ -0,0 +1,27 @@
+# Utilize the Node.js 14 official image


Why node 14?

Outdated comment, have updated

prakashchoudhary07 · 2024-09-11T19:01:49Z

Dockerfile

@@ -0,0 +1,27 @@
+# Utilize the Node.js 14 official image
+FROM node:18-alpine


What is the current latest version?

Current version in v20.17.0 using this one because in our volta package 18 version is pinned

prakashchoudhary07 · 2024-09-11T19:02:20Z

Dockerfile

+USER root
+
+# Set the working directory inside the container
+WORKDIR /app
+
+# Copy the package.json and package-lock.json (if available)
+# COPY package*.json ./
+
+# Install the dependencies
+
+
+# Copy the rest of the application code
+COPY . .
+
+RUN yarn install --frozen-lockfile
+
+# Build the Fastboot app
+RUN yarn build
+
+# Expose the port the Fastboot app runs on
+EXPOSE 5000
+
+# Define the command to run your Fastboot app
+CMD ["node", "fastboot-server"]


How does the app know in which env to run

For this we can have a two docker file one for production and one for staging with two different build commands

draft: write initial docker file

943620c

satyam73 self-assigned this Sep 6, 2024

satyam73 marked this pull request as draft September 6, 2024 20:30

prakashchoudhary07 reviewed Sep 11, 2024

View reviewed changes

satyam73 added 2 commits September 15, 2024 02:17

chore: update docker file and cleanup

9df96df

Merge branch 'develop' into setup/dockerize-app

43a5ed7

satyam73 marked this pull request as ready for review September 15, 2024 12:16

satyam73 changed the title ~~draft: write initial docker file~~ setup: add docker file Sep 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

setup: add docker file #930

setup: add docker file #930

satyam73 commented Sep 4, 2024

cloudflare-workers-and-pages bot commented Sep 4, 2024 •

edited

Loading

satyam73 commented Sep 6, 2024 •

edited

Loading

prakashchoudhary07 Sep 11, 2024

satyam73 Sep 14, 2024 •

edited

Loading

prakashchoudhary07 Sep 11, 2024

satyam73 Sep 14, 2024

prakashchoudhary07 Sep 11, 2024

satyam73 Sep 14, 2024

prakashchoudhary07 Sep 11, 2024

satyam73 Sep 14, 2024

prakashchoudhary07 Sep 11, 2024

satyam73 Sep 14, 2024 •

edited

Loading

		// API_BACKEND: `${SCHEME}api.${DOMAIN}`,hostWhitelist

		API_BACKEND: `http://localhost:3000`,

		@@ -0,0 +1,27 @@
		# Utilize the Node.js 14 official image
		FROM node:18-alpine

setup: add docker file #930

Are you sure you want to change the base?

setup: add docker file #930

Conversation

satyam73 commented Sep 4, 2024

Issue Ticket Number:-

Description:

Add relevant Screenshot below ( e.g test coverage etc. )

cloudflare-workers-and-pages bot commented Sep 4, 2024 • edited Loading

Deploying www-rds with Cloudflare Pages

satyam73 commented Sep 6, 2024 • edited Loading

For docker

For without docker

Update

Updated steps to run docker

Choose a reason for hiding this comment

satyam73 Sep 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

satyam73 Sep 14, 2024 • edited Loading

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Sep 4, 2024 •

edited

Loading

satyam73 commented Sep 6, 2024 •

edited

Loading

satyam73 Sep 14, 2024 •

edited

Loading

satyam73 Sep 14, 2024 •

edited

Loading