Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suscription feature testcases #945

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

tejaskh3
Copy link
Member

@tejaskh3 tejaskh3 commented Oct 22, 2024

Date: 22 oct, 2024

Developer Name: @tejaskh3


Issue Ticket Number:-

Description:

  • this PR consists the test cases for the subscription feature.

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • [] No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Tested in staging?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

image

@tejaskh3 tejaskh3 self-assigned this Oct 22, 2024
@tejaskh3 tejaskh3 mentioned this pull request Oct 22, 2024
9 tasks
Base automatically changed from new-subcription-feature to develop October 23, 2024 20:44
@tejaskh3 tejaskh3 force-pushed the suscription-feature-test branch from 924388b to 24956f0 Compare October 23, 2024 20:55
Copy link

cloudflare-workers-and-pages bot commented Oct 23, 2024

Deploying www-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: 982d066
Status: ✅  Deploy successful!
Preview URL: https://097117b0.www-rds.pages.dev
Branch Preview URL: https://suscription-feature-test.www-rds.pages.dev

View logs

@tejaskh3 tejaskh3 force-pushed the suscription-feature-test branch from 24956f0 to 0ff4501 Compare October 23, 2024 21:14
Comment on lines +1 to +2
export const phoneNumberRegex =
/^[+]{1}(?:[0-9\-\\(\\)\\/.]\s?){6,15}[0-9]{1}$/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @tejaskh3, I see we are not using any regex in tests. and that too from this file.

Do we need it?

Comment on lines +6 to +9
module('Integration | Component | subscribe', function (hooks) {
setupRenderingTest(hooks);

test('subscribe form renders and functions correctly', async function (assert) {
Copy link
Member

@MehulKChaudhari MehulKChaudhari Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you are writing an integration test for template/subscription.hbs

For template files like this, we typically write acceptance tests, not integration tests. This is because we want to simulate the full user experience by testing what the user sees when they visit the /subscription (in this case) route and how the application responds to user interactions. Acceptance tests cover aspects like navigating between routes, verifying that the correct content is displayed, and checking how user actions, such as clicks, affect the current route or trigger redirection.

Integration tests are used to test individual components to ensure they render correctly and behave as expected in isolation, including how they respond to different inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants