-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suscription feature testcases #945
base: develop
Are you sure you want to change the base?
Conversation
924388b
to
24956f0
Compare
Deploying www-rds with Cloudflare Pages
|
24956f0
to
0ff4501
Compare
export const phoneNumberRegex = | ||
/^[+]{1}(?:[0-9\-\\(\\)\\/.]\s?){6,15}[0-9]{1}$/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tejaskh3, I see we are not using any regex in tests. and that too from this file.
Do we need it?
module('Integration | Component | subscribe', function (hooks) { | ||
setupRenderingTest(hooks); | ||
|
||
test('subscribe form renders and functions correctly', async function (assert) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that you are writing an integration test for template/subscription.hbs
For template files like this, we typically write acceptance tests, not integration tests. This is because we want to simulate the full user experience by testing what the user sees when they visit the /subscription
(in this case) route and how the application responds to user interactions. Acceptance tests cover aspects like navigating between routes, verifying that the correct content is displayed, and checking how user actions, such as clicks, affect the current route or trigger redirection.
Integration tests are used to test individual components to ensure they render correctly and behave as expected in isolation, including how they respond to different inputs.
Date: 22 oct, 2024
Developer Name: @tejaskh3
Issue Ticket Number:-
link
This is stacked PR to subscription feature fixes #944, so please merge this PR after subscription feature fixes #944
Description:
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )