added login route #961
Merged
added login route #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please break the PR so it is easy to review |
@vinit717 most of the changes there are around templating/css and some js for component/routing logic, |
I'll suggest to break the PR as test case is also missing like header part |
prakashchoudhary07
requested changes
Dec 13, 2024
Achintya-Chatterjee
previously approved these changes
Dec 22, 2024
Achintya-Chatterjee
previously approved these changes
Dec 29, 2024
devprakash0
approved these changes
Jan 3, 2025
iamitprakash
requested changes
Jan 3, 2025
@iamitprakash have updated both the screenshots. |
iamitprakash
approved these changes
Jan 3, 2025
iamitprakash
added a commit
that referenced
this pull request
Jan 6, 2025
* Updated deprecated API endpoint from /users/self to /users?profile=true (#960) * added login route (#961) * added login route * changed styles, templates & scripts * minor changes in scripts * updated css * css changes * sentence correction (#971) --------- Co-authored-by: Hariom Vashista <[email protected]> Co-authored-by: Sameer Supe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Date:
10/12/24Developer Name:
Sameer SupeIssue Ticket Number:-
Description:
adds a new login route with new added auth option for google login.
refer design doc & PRD for more details.
note:
this feature is dependent on backend pr.
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Is Development Tested?
Tested in staging?
Add relevant Screenshot below ( e.g test coverage etc. )
Screenshot
loginRoute.mp4
Screenshot 2
devRoleErr.mp4
Test Coverage
Screenshot