Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[My Site Migration] Identity Linking get started page #965

Merged
merged 7 commits into from
Jan 6, 2025

Conversation

tejaskh3
Copy link
Member

@tejaskh3 tejaskh3 commented Jan 4, 2025

Date: 5 Jan, 2024

Developer Name: @tejaskh3


Issue Ticket Number:-

Please don't close this issue #962

Description:

  • this is the very first PR for the identity linking page
  • in this PR we are adding the get started page and created a base to migrate this feature
  • this feature will have 4 more such PRs which will consist of lot of file changes, I have broke it down in multiple PRs.

Add description of the PR here

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

image

image

@tejaskh3 tejaskh3 self-assigned this Jan 4, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2025

Deploying www-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76ec616
Status: ✅  Deploy successful!
Preview URL: https://ad81b5a4.www-rds.pages.dev
Branch Preview URL: https://feat-identiy-linking.www-rds.pages.dev

View logs

@tejaskh3 tejaskh3 marked this pull request as draft January 4, 2025 16:57
@tejaskh3 tejaskh3 force-pushed the feat/identiy-linking branch from 6463b7a to f257b9a Compare January 4, 2025 16:58
@tejaskh3 tejaskh3 changed the title Feat/identiy linking [My Site Migration] Identity Linking get started page Jan 4, 2025
@tejaskh3 tejaskh3 marked this pull request as ready for review January 4, 2025 18:36
MehulKChaudhari
MehulKChaudhari previously approved these changes Jan 4, 2025
Copy link
Member

@MehulKChaudhari MehulKChaudhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the .DS_Store we dont need it in GitHub

@tejaskh3
Copy link
Member Author

tejaskh3 commented Jan 4, 2025

Please remove the .DS_Store we dont need it in GitHub

I can't see any .DS_Store file in my local, let me figure out why it came here.

@MehulKChaudhari MehulKChaudhari dismissed stale reviews from Achintya-Chatterjee and themself via b102f6c January 4, 2025 22:20
@tejaskh3 tejaskh3 requested a review from iamitprakash January 6, 2025 10:22
@tejaskh3 tejaskh3 removed the request for review from iamitprakash January 6, 2025 17:30
@iamitprakash iamitprakash merged commit d598b30 into develop Jan 6, 2025
3 checks passed
@iamitprakash iamitprakash deleted the feat/identiy-linking branch January 6, 2025 18:43
@tejaskh3 tejaskh3 mentioned this pull request Jan 12, 2025
10 tasks
iamitprakash added a commit that referenced this pull request Jan 15, 2025
* [My Site Migration] Identity Linking get started page (#965)

* resolve merge commits

* feat: add get started page

* remove: unused auth url

* fix: css for get started on identity page

* feat: add identity page behind feature flag

* nit: remove unwanted .DS_store

---------

Co-authored-by: Mehul Kiran Chaudhari <[email protected]>

* [My Site Migration] Identity Linking step1 page (#966)

* resolve merge commits

* feat: add get started page

* remove: unused auth url

* fix: css for get started on identity page

* feat: add identity page behind feature flag

* feat: setp1 page in identity linking

* remove: unused redirect-auth util

* Remove .DS_Store files from repository

* feat: add varaible css

* feat: add varaible css

* refactor(970): moves notices for joining to its own component (#972)

* feat(970): moves notices for joining to its own component

We were copying the same notice for joining in two places. This moves it to its own component, so future changes are easier.

* refactor(970): added review changes: year - 2024

* refactor(970): fixed messaging for joining

---------

Co-authored-by: Amit Prakash <[email protected]>
Co-authored-by: Achintya Chatterjee <[email protected]>

* [My Site Migration] Identity Linking step2,3 page (#967)

* resolve merge commits

* feat: add get started page

* remove: unused auth url

* fix: css for get started on identity page

* feat: add identity page behind feature flag

* feat: setp1 page in identity linking

* remove: unused redirect-auth util

* Remove .DS_Store files from repository

* feat: add varaible css

* feat: add varaible css

* feat: add step2 on identity linking page

* feat: add step2 and step3 page

* feat: add reload step

* feat: add varaible css

---------

Co-authored-by: TEJAS <[email protected]>
Co-authored-by: Mehul Kiran Chaudhari <[email protected]>
Co-authored-by: Ankush Dharkar <[email protected]>
Co-authored-by: Amit Prakash <[email protected]>
Co-authored-by: Lakshay Manchanda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants