Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[My Site Migration] Identity Linking step2,3 page #967

Merged
merged 16 commits into from
Jan 13, 2025

Conversation

tejaskh3
Copy link
Member

@tejaskh3 tejaskh3 commented Jan 4, 2025

Date: 5 Jan, 2024

Developer Name: @tejaskh3


Issue Ticket Number:-

Please don't close this issue #962

Description:

  • this is the third PR for the identity linking page
  • in this PR we are creating step2,3 page for identity linking feature

Add description of the PR here

Is Under Feature Flag

  • Yes
  • No

Database changes

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

  • Yes
  • No

Is Development Tested?

  • Yes
  • No

Add relevant Screenshot below ( e.g test coverage etc. )

image

image

@tejaskh3 tejaskh3 changed the base branch from develop to feat/identiy-linking-step1 January 4, 2025 20:51
@tejaskh3 tejaskh3 changed the title [My Site Migration] Identity Linking step2 page [My Site Migration] Identity Linking step2,3 page Jan 4, 2025
Copy link

cloudflare-workers-and-pages bot commented Jan 4, 2025

Deploying www-rds with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3351ef1
Status: ✅  Deploy successful!
Preview URL: https://718e74b8.www-rds.pages.dev
Branch Preview URL: https://feat-identity-linking-step2.www-rds.pages.dev

View logs

@tejaskh3 tejaskh3 self-assigned this Jan 4, 2025
MehulKChaudhari
MehulKChaudhari previously approved these changes Jan 4, 2025
@tejaskh3 tejaskh3 requested a review from iamitprakash January 6, 2025 10:23
lakshayman
lakshayman previously approved these changes Jan 6, 2025
Base automatically changed from feat/identiy-linking-step1 to develop January 9, 2025 19:38
@lakshayman lakshayman dismissed stale reviews from MehulKChaudhari, Achintya-Chatterjee, and themself January 9, 2025 19:38

The base branch was changed.

@tejaskh3 tejaskh3 force-pushed the feat/identity-linking-step2 branch from 3aec7d0 to edea633 Compare January 9, 2025 19:47
@tejaskh3 tejaskh3 removed the request for review from iamitprakash January 13, 2025 08:03
@lakshayman lakshayman merged commit db73357 into develop Jan 13, 2025
3 checks passed
@lakshayman lakshayman deleted the feat/identity-linking-step2 branch January 13, 2025 21:09
iamitprakash added a commit that referenced this pull request Jan 15, 2025
* [My Site Migration] Identity Linking get started page (#965)

* resolve merge commits

* feat: add get started page

* remove: unused auth url

* fix: css for get started on identity page

* feat: add identity page behind feature flag

* nit: remove unwanted .DS_store

---------

Co-authored-by: Mehul Kiran Chaudhari <[email protected]>

* [My Site Migration] Identity Linking step1 page (#966)

* resolve merge commits

* feat: add get started page

* remove: unused auth url

* fix: css for get started on identity page

* feat: add identity page behind feature flag

* feat: setp1 page in identity linking

* remove: unused redirect-auth util

* Remove .DS_Store files from repository

* feat: add varaible css

* feat: add varaible css

* refactor(970): moves notices for joining to its own component (#972)

* feat(970): moves notices for joining to its own component

We were copying the same notice for joining in two places. This moves it to its own component, so future changes are easier.

* refactor(970): added review changes: year - 2024

* refactor(970): fixed messaging for joining

---------

Co-authored-by: Amit Prakash <[email protected]>
Co-authored-by: Achintya Chatterjee <[email protected]>

* [My Site Migration] Identity Linking step2,3 page (#967)

* resolve merge commits

* feat: add get started page

* remove: unused auth url

* fix: css for get started on identity page

* feat: add identity page behind feature flag

* feat: setp1 page in identity linking

* remove: unused redirect-auth util

* Remove .DS_Store files from repository

* feat: add varaible css

* feat: add varaible css

* feat: add step2 on identity linking page

* feat: add step2 and step3 page

* feat: add reload step

* feat: add varaible css

---------

Co-authored-by: TEJAS <[email protected]>
Co-authored-by: Mehul Kiran Chaudhari <[email protected]>
Co-authored-by: Ankush Dharkar <[email protected]>
Co-authored-by: Amit Prakash <[email protected]>
Co-authored-by: Lakshay Manchanda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants