Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve markdown processing #26

Merged
merged 4 commits into from
Jul 20, 2023
Merged

feat: improve markdown processing #26

merged 4 commits into from
Jul 20, 2023

Conversation

Weetbix
Copy link
Collaborator

@Weetbix Weetbix commented Jul 19, 2023

This PR improves the markdown preprocessing and fixes these issues, improving the score accuracy:

  • Adds periods to list items
  • Converts colons to periods
  • Process tables as text

Note:

  • Switched from jest to vitest due to the remarker upgrade, plays nicer with esm modules.

@Weetbix Weetbix requested a review from noon-dawg July 19, 2023 05:02
@Weetbix Weetbix force-pushed the jh/readability-score-improvements branch from d5914e7 to 87a9866 Compare July 19, 2023 05:04
noon-dawg
noon-dawg approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@noon-dawg noon-dawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@Weetbix Weetbix merged commit 6f4d4ab into main Jul 20, 2023
@Weetbix Weetbix deleted the jh/readability-score-improvements branch July 20, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noon-dawg noon-dawg noon-dawg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weetbix @noon-dawg