Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: improve parsing #35

Merged
merged 6 commits into from
Jul 31, 2023
Merged

Fix: improve parsing #35

merged 6 commits into from
Jul 31, 2023

Conversation

Weetbix
Copy link
Collaborator

@Weetbix Weetbix commented Jul 28, 2023

This PR improves the parsing in several ways:

  • Remove strip usage, it was not preserving new lines and causing big issues with periods between sentences.like this.
  • Replaced strip with custom parsing
  • Fix frontmatter parsing / throwing away

@Weetbix Weetbix requested a review from noon-dawg July 28, 2023 06:42
@Weetbix Weetbix force-pushed the jh/improve-parsing branch 4 times, most recently from 2e519fb to 448823d Compare July 31, 2023 03:23
noon-dawg
noon-dawg approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@noon-dawg noon-dawg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Weetbix Weetbix merged commit a2d522c into main Jul 31, 2023
5 checks passed
@Weetbix Weetbix deleted the jh/improve-parsing branch July 31, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noon-dawg noon-dawg noon-dawg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Weetbix @noon-dawg