Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add pre-checks to avoid failing at a later stage #277

Open
wants to merge 4 commits into
base: devel
Choose a base branch
from

Conversation

ableischwitz
Copy link
Contributor

  • remove OpenShift 4.12 / IPv6 installation blocker (issue didn't show up during tests)
  • add 00-provision-hetzner.yml to setup.yml as it doesn't do anything unless requested.
  • rename import_playbook to ansible.builtin.import_playbook.

Description

Checklist/ToDo's

  • Added documentation?
  • Added release note entry? ( docs/release-notes.md )
  • Tested?

 - remove OpenShift 4.12 / IPv6 installation blocker (issue didn't show up during tests)
 - add `00-provision-hetzner.yml` to `setup.yml` as it doesn't do anything unless requested.
 - rename `import_playbook` to `ansible.builtin.import_playbook`.
@rbo
Copy link
Contributor

rbo commented May 13, 2023

/ok-to-test

@skull-cicd
Copy link

skull-cicd bot commented May 13, 2023

💀 There was an error during pre-commit / linter:

[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git:.[community,yamllint].
[INFO] Installing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Ansible-lint.............................................................Failed
- hook id: ansible-lint
- exit code: 2

[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
WARNING  Loading custom .yamllint config file, this extends our internal yamllint config.
WARNING  Listing 1 violation(s) that are fatal
yaml: wrong indentation: expected 4 but found 2 (indentation)
ansible/00-check-cluster-config.yml:9

You can skip specific rules or tags by adding them to your configuration file:
# .ansible-lint
warn_list:  # or 'skip_list' to silence them completely
  - yaml  # Violations reported by yamllint

Finished with 1 failure(s), 0 warning(s) on 168 files.

 - remove OpenShift 4.12 / IPv6 installation blocker (issue didn't show up during tests)
 - add `00-provision-hetzner.yml` to `setup.yml` as it doesn't do anything unless requested.
 - rename `import_playbook` to `ansible.builtin.import_playbook`.
 - fixed 00-check-cluster-config.yml indentation
@skull-cicd
Copy link

skull-cicd bot commented Jun 7, 2023

💀 There was an error during pre-commit / linter:

[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Initializing environment for https://github.com/ansible-community/ansible-lint.git:.[community,yamllint].
[INFO] Installing environment for https://github.com/ansible-community/ansible-lint.git.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Ansible-lint.............................................................Failed
- hook id: ansible-lint
- exit code: 1

[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
[WARNING]: Ansible is being run in a world writable directory
(/workspace/source), ignoring it as an ansible.cfg source. For more information
see
https://docs.ansible.com/ansible/devel/reference_appendices/config.html#cfg-in-
world-writable-dir
WARNING  Loading custom .yamllint config file, this extends our internal yamllint config.
an AnsibleCollectionFinder has not been installed in this process

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants