Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to appsre unleash #799

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from
Draft

Migrate to appsre unleash #799

wants to merge 13 commits into from

Conversation

Victoremepunto
Copy link
Contributor

No description provided.

@psav psav added enhancement New feature or request pr-functional-change Will result in a new binary labels Jun 16, 2023
@Victoremepunto Victoremepunto force-pushed the migrate-to-appsre-unleash branch 2 times, most recently from 21e83d8 to 8ba0d50 Compare December 4, 2023 13:35
@Victoremepunto Victoremepunto force-pushed the migrate-to-appsre-unleash branch 4 times, most recently from e594989 to 9398122 Compare December 20, 2023 16:19
@Victoremepunto
Copy link
Contributor Author

Unsure at this point if this is worth it at all.

  • Can't use (or don't know how to use) public routes for Keycloak (so Unleash's GUI is disabled to all effects)
  • Having AppSRE's Unleash adds little to no value compared to Vanilla Unleash with GUI disabled (in fact we loose that compared to vanilla Unleash)
  • To fix the kuttl test, it REALLY needs to do better than rely on wget command present in the image, extending the scope of this PR.

May be superseded (again) by simply #912

@adamrdrew @psav I'd appreciate your thoughts here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request pr-functional-change Will result in a new binary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Victoremepunto @psav