Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(APIv2): enforce pundit policies when resolving entities #1870

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix(APIv2): enforce pundit policies when resolving entities #1870

merged 1 commit into from
Nov 13, 2023

Conversation

skateman
Copy link
Member

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@skateman skateman added the APIv2 REST API v2 label Nov 13, 2023
@skateman skateman requested a review from a team as a code owner November 13, 2023 11:52
@skateman skateman enabled auto-merge (rebase) November 13, 2023 11:53
romanblanco
romanblanco approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@romanblanco romanblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
app/controllers/v2/application_controller.rb 100.00% <100.00%> (+1.92%) ⬆️

📢 Thoughts on this report? Let us know!

@skateman skateman disabled auto-merge November 13, 2023 12:08
@skateman skateman merged commit 49da51c into RedHatInsights:master Nov 13, 2023
6 checks passed
@skateman skateman deleted the pundit-v2 branch November 13, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanblanco romanblanco romanblanco approved these changes

Assignees
No one assigned
Labels
APIv2 REST API v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skateman @romanblanco