Merge pull request #2679 from karelhala/no-empty-bundle

Do not include empty bundle in navigations
RedHatInsights · Nov 3, 2023 · 92e3d7c · 92e3d7c
2 parents e740df9 + d6638e4
commit 92e3d7c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/components/AppFilter/useAppFilter.test.js b/src/components/AppFilter/useAppFilter.test.js
@@ -91,7 +91,7 @@ describe('useAppFilter', () => {
     await act(async () => {
       result.current.setIsOpen(true);
     });
-    expect(axiosGetSpy).toHaveBeenCalledTimes(11);
+    expect(axiosGetSpy).toHaveBeenCalledTimes(10);
     for (let index = 0; index < 8; index++) {
       expect(axiosGetSpy.mock.calls[index]).toEqual([
         `/api/chrome-service/v1/static/stable/stage/navigation/${requiredBundles[index]}-navigation.json?ts=666`,

diff --git a/src/components/AppFilter/useAppFilter.ts b/src/components/AppFilter/useAppFilter.ts
@@ -26,7 +26,7 @@ export const requiredBundles = [
   'business-services',
   'subscriptions',
   ...(!isProd() ? previewBundles : isBeta() ? previewBundles : []),
-];
+].filter(Boolean);
 
 export const itLessBundles = ['openshift', 'insights', 'settings', 'iam'];