Fix URL format bug by using latest version of url dependency #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InsaneZein
approved these changes
Oct 5, 2023
Codecov Report
@@ Coverage Diff @@
## master #2652 +/- ##
==========================================
- Coverage 57.49% 52.60% -4.90%
==========================================
Files 93 93
Lines 2842 2498 -344
Branches 661 451 -210
==========================================
- Hits 1634 1314 -320
+ Misses 1133 816 -317
- Partials 75 368 +293 |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When slecting sap SIDs in global filter the requests for all host based resources are failing with 500. This is because of incorrect envoding of arrays in query parameters. This is caused by URL dependency which had a bug fixed last month defunctzombie/node-url#65
JIRA
RHCLOUD-28622