Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrollbar to Services Dropdown tabs #2657

Closed
wants to merge 2 commits into from
Closed

Add scrollbar to Services Dropdown tabs #2657

wants to merge 2 commits into from

Conversation

epwinchell
Copy link
Contributor

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #2657 (bc93218) into master (7c76a1b) will not change coverage.
The diff coverage is n/a.

❗ Current head bc93218 differs from pull request most recent head 829b891. Consider uploading reports for the commit 829b891 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2657   +/-   ##
=======================================
  Coverage   57.47%   57.47%           
=======================================
  Files          93       93           
  Lines        2843     2843           
  Branches      662      582   -80     
=======================================
  Hits         1634     1634           
- Misses       1134     1208   +74     
+ Partials       75        1   -74

see 25 files with indirect coverage changes

@epwinchell epwinchell requested a review from a team October 9, 2023 19:29
Hyperkid123
Hyperkid123 reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@Hyperkid123 Hyperkid123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes scrollbars to be visible at all times. Even if there is enough space and it also adds them to the horizontal axis:
screenshot-stage foo redhat com_1337-2023 10 10-08_59_39

@epwinchell epwinchell marked this pull request as draft October 10, 2023 11:51
@Hyperkid123
Copy link
Contributor

Stale PR. Please reopen if still valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hyperkid123 Hyperkid123 Hyperkid123 left review comments

@ryelo ryelo Awaiting requested review from ryelo ryelo is a code owner

@karelhala karelhala Awaiting requested review from karelhala karelhala is a code owner

@florkbr florkbr Awaiting requested review from florkbr florkbr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epwinchell @codecov-commenter @Hyperkid123