Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-28295: update chrome to use autosuggest search API #2658

Merged
merged 5 commits into from
Nov 2, 2023

Conversation

florkbr
Copy link
Contributor

@florkbr florkbr commented Oct 9, 2023

CC @Hyperkid123

I'm still testing things out - namely trying to figure out if autosuggest supports typos. For example - opensift returns no results with the new API.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2023

Codecov Report

Merging #2658 (0ed054c) into master (d6f0a38) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 0ed054c differs from pull request most recent head eeda7c1. Consider uploading reports for the commit eeda7c1 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2658      +/-   ##
==========================================
+ Coverage   57.20%   57.21%   +0.01%     
==========================================
  Files          94       95       +1     
  Lines        2860     2861       +1     
  Branches      668      588      -80     
==========================================
+ Hits         1636     1637       +1     
- Misses       1148     1223      +75     
+ Partials       76        1      -75     
Files Coverage Δ
src/components/Search/SearchTypes.ts 100.00% <100.00%> (ø)

... and 25 files with indirect coverage changes

@Hyperkid123
Copy link
Contributor

CC @Hyperkid123

I'm still testing things out - namely trying to figure out if autosuggest supports typos. For example - opensift returns no results with the new API.

We might need the second query after all. With the fuzzy range. Say if we get less than 10 results.

@florkbr
Copy link
Contributor Author

florkbr commented Oct 12, 2023

Update: the search team is taking a look at adding the ability to fuzzy search for us. I'm reworking this PR to fall back to our old logic - however we should give that new fuzzy match a shot too.

@Hyperkid123
Copy link
Contributor

Yup, let's just wait for what we get once they are finished.

@Hyperkid123 Hyperkid123 changed the title [WIP] RHCLOUD-28295: update chrome to use autosuggest search API RHCLOUD-28295: update chrome to use autosuggest search API Nov 1, 2023
@Hyperkid123
Copy link
Contributor

Added a commit to address the larger issues. We are forced to swap away to help the search team debug their perf issues.

@Hyperkid123
Copy link
Contributor

/retest

@Hyperkid123 Hyperkid123 merged commit e740df9 into RedHatInsights:master Nov 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants