-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHCLOUD-28295: update chrome to use autosuggest search API #2658
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2658 +/- ##
==========================================
+ Coverage 57.20% 57.21% +0.01%
==========================================
Files 94 95 +1
Lines 2860 2861 +1
Branches 668 588 -80
==========================================
+ Hits 1636 1637 +1
- Misses 1148 1223 +75
+ Partials 76 1 -75
|
We might need the second query after all. With the fuzzy range. Say if we get less than 10 results. |
Update: the search team is taking a look at adding the ability to fuzzy search for us. I'm reworking this PR to fall back to our old logic - however we should give that new fuzzy match a shot too. |
Yup, let's just wait for what we get once they are finished. |
Added a commit to address the larger issues. We are forced to swap away to help the search team debug their perf issues. |
8ddb25a
to
afafff9
Compare
/retest |
afafff9
to
66ad46a
Compare
CC @Hyperkid123
I'm still testing things out - namely trying to figure out if autosuggest supports typos. For example -
opensift
returns no results with the new API.