Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hac SDKv4 compatibility layer. #2663

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Add hac SDKv4 compatibility layer. #2663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/components/RootApp/ScalprumRoot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import Footer, { FooterProps } from '../Footer/Footer';
import updateSharedScope from '../../chrome/update-shared-scope';
import useBundleVisitDetection from '../../hooks/useBundleVisitDetection';
import chromeApiWrapper from './chromeApiWrapper';
import { ITLess } from '../../utils/common';
import { ITLess, isBeta } from '../../utils/common';
import InternalChromeContext from '../../utils/internalChromeContext';
import useChromeServiceEvents from '../../hooks/useChromeServiceEvents';
import { populateNotifications } from '../../redux/actions';
Expand Down Expand Up @@ -170,15 +170,16 @@ const ScalprumRoot = memo(
loadScripts: [],
};
}
return {
const newManifest = {
...manifest,
// Compatibility required for bot pure SDK plugins, HCC plugins and sdk v1/v2 plugins until all are on the same system.
baseURL: '/',
baseURL: manifest.name.includes('hac-') && !manifest.baseURL ? `${isBeta() ? '/beta' : ''}/api/plugins/${manifest.name}/` : '/',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously not an ideal solution here... Hopefully we can remove this in the near future when we migrate hac-dev

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They will have to update the build SDK to at least v3 for use to be able to remove it.

loadScripts: manifest.loadScripts?.map((script) => `${manifest.baseURL}${script}`.replace(/\/\//, '/')) ?? [
`${manifest.baseURL ?? ''}plugin-entry.js`,
],
registrationMethod: manifest.registrationMethod ?? 'callback',
};
return newManifest;
},
},
},
Expand Down
Loading