Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependencies): update react to v 18 #90

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

karelhala
Copy link
Contributor

BREAKING CHANGE: React 18 brings a few improvements and requires updating other libraries

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e6b152e) 88.79% compared to head (2abdb61) 88.79%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #90   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files          60       60           
  Lines         937      937           
  Branches      166      166           
=======================================
  Hits          832      832           
  Misses        105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karelhala karelhala requested review from a team and josejulio January 18, 2024 16:01
Copy link
Member

@josejulio josejulio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@Hyperkid123
Copy link
Contributor

@karelhala I see both package-lock.json and yarn.lock? Should we just switch to npm and remove the yarn lock as there is so many dependency changes anyways?

BREAKING CHANGE: React 18 brings a few improvements and requires updating other libraries
@Hyperkid123 Hyperkid123 merged commit ff728ed into RedHatInsights:master Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants