Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onchange callback): change sending event instead of value #95

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

karelhala
Copy link
Contributor

Description

Users are unable to type anything in TextInputs, this PR fixes it by passing correct values to onChange callback.

@karelhala karelhala requested a review from a team April 5, 2024 09:14
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.36%. Comparing base (4e20e52) to head (749c05e).
Report is 2 commits behind head on master.

Files Patch % Lines
...escript/src/components/Formik/Patternfly/Common.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files          60       60           
  Lines         959      959           
  Branches      181      181           
=======================================
  Hits          857      857           
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@karelhala karelhala merged commit a2e2537 into RedHatInsights:master Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants