feat: add detailed view to Workspaces #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekkaluzik
force-pushed
the
RHCLOUD-31942
branch
4 times, most recently
from
9e3af2b to
ef32681
Compare
radekkaluzik
force-pushed
the
RHCLOUD-31942
branch
4 times, most recently
from
19dd10d to
4f3bd5a
Compare
|
/retest |
1 similar comment
|
/retest |
fhlavac
reviewed
Nov 8, 2024
fhlavac
reviewed
Nov 8, 2024
| }, [dispatch]); | ||
|
|
||
| const buildWorkspacesHierarchy = (workspaces: any[], workspaceId: string): WorkspaceData[] => { | ||
| let currentWorkspace = workspaces.find((ws) => ws.uuid === workspaceId); |
There was a problem hiding this comment.
you can probably use selectedWorkspace
There was a problem hiding this comment.
I'm not sure if I can do that assuming that selectedWorkspace is mainly used to get workspace name and description in the header and we don't want that to be changed after the page gets loaded.
fhlavac
reviewed
Nov 8, 2024
|
The application-level breadcrumbs do not seem to be working in the detail It should probably contain |
radekkaluzik
force-pushed
the
RHCLOUD-31942
branch
from
4f3bd5a to
214b417
Compare
karelhala
reviewed
Nov 8, 2024
radekkaluzik
force-pushed
the
RHCLOUD-31942
branch
2 times, most recently
from
393e9e8 to
fb54a6c
Compare
This will be fixed by: #1699 |
karelhala
reviewed
Nov 12, 2024
radekkaluzik
force-pushed
the
RHCLOUD-31942
branch
from
fb54a6c to
6b7fcef
Compare
karelhala
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of Workspace detail, navigation tab, action menu and workspace hierarchy breadcrumb. Data is mocked at the moment and needs to be connected to the API when ready.
RHCLOUD-31942
Screenshots
Checklist ☑️