Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(permission): unable to load more than 2 pages in permissions #1688

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

karelhala
Copy link
Contributor

@karelhala karelhala commented Oct 29, 2024

Description

Currently users are unable to navigate to more than second page of permissions because it's dispatching only 2nd page in state. This PR fixes it by changing increment to plus.

RHCLOUD-35972


Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • [-] (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • [-] (Optional) QE: Has been mentioned
  • [-] (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • [-] (Optional) UX: Has been mentioned

@karelhala karelhala requested a review from a team October 29, 2024 15:49
@karelhala karelhala merged commit 2d08c25 into RedHatInsights:master Oct 29, 2024
10 checks passed
CodyWMitchell pushed a commit to CodyWMitchell/insights-rbac-ui that referenced this pull request Nov 4, 2024
CodyWMitchell pushed a commit to CodyWMitchell/insights-rbac-ui that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants